-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KeyringController state issues #35
Labels
bug
Something isn't working
Comments
mcmire
pushed a commit
to mcmire/core
that referenced
this issue
Jul 17, 2023
* Extract build-only TypeScript config * Fix type issues
kanthesha
pushed a commit
that referenced
this issue
Sep 19, 2023
kanthesha
pushed a commit
that referenced
this issue
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this issue
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this issue
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this issue
Oct 12, 2023
We believe the KeyringController has changed significantly since this issue was opened and feel this issue is outdated. If the original author has additional context or believes it is still an issue please feel free to reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There's something funky going on with the state of the
KeyringController
. Specifically with the propertykeyrings
.Once the property is updated via
fullUpdate
which internally callsupdate
, the new value is not accessible via state (still has the default value) but it's fine if you access it via context.How to reproduce from the app:
1 - Log in
2 - To verify that the value has been set, log
Engine.context.KeyringController.state.keyrings
=>[{ type: 'HD Keyring', accounts: ['0x...']}]
3 - Now try to access it through state, log
Engine.state.KeyringController.keyrings
=>[]
The text was updated successfully, but these errors were encountered: