Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyringController state issues #35

Closed
brunobar79 opened this issue Dec 3, 2018 · 1 comment
Closed

KeyringController state issues #35

brunobar79 opened this issue Dec 3, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@brunobar79
Copy link
Contributor

There's something funky going on with the state of the KeyringController. Specifically with the property keyrings.

Once the property is updated via fullUpdate which internally calls update, the new value is not accessible via state (still has the default value) but it's fine if you access it via context.

How to reproduce from the app:
1 - Log in
2 - To verify that the value has been set, log Engine.context.KeyringController.state.keyrings => [{ type: 'HD Keyring', accounts: ['0x...']}]
3 - Now try to access it through state, logEngine.state.KeyringController.keyrings => []
@Gudahtt Gudahtt added the bug Something isn't working label Nov 4, 2021
@mcmire mcmire mentioned this issue Mar 23, 2022
Closed
35 tasks
mcmire pushed a commit to mcmire/core that referenced this issue Jul 17, 2023
@Mrtenz
Extract build-only TypeScript config (MetaMask#35)
7526766 
* Extract build-only TypeScript config

* Fix type issues
kanthesha pushed a commit that referenced this issue Sep 19, 2023
@jpuri
Add early return if JSON RPC request is not found (#35)
4b090ef
kanthesha pushed a commit that referenced this issue Oct 11, 2023
@whymarrh
Update mocha, mkdirp, & minimist (#35)
0a51db7
MajorLift pushed a commit that referenced this issue Oct 11, 2023
@jpuri @MajorLift
Add early return if JSON RPC request is not found (#35)
67d2c71
MajorLift pushed a commit that referenced this issue Oct 11, 2023
@jpuri @MajorLift
Add early return if JSON RPC request is not found (#35)
0307317
MajorLift pushed a commit that referenced this issue Oct 12, 2023
@jpuri @MajorLift
Add early return if JSON RPC request is not found (#35)
e98bfa2
@desi
Copy link

desi commented Apr 22, 2024

We believe the KeyringController has changed significantly since this issue was opened and feel this issue is outdated. If the original author has additional context or believes it is still an issue please feel free to reopen.

@desi desi closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@desi @bitpshr @brunobar79 @Gudahtt