Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Not able to switch to Linea Sepolia Test Network #9111

Closed
chrisleewilcox opened this issue Apr 1, 2024 · 0 comments · Fixed by #9123
Closed

[Bug]: Not able to switch to Linea Sepolia Test Network #9111

chrisleewilcox opened this issue Apr 1, 2024 · 0 comments · Fixed by #9123
Labels
regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-7.20.0 release-7.20.0 Issue or pull request that will be included in release 7.20.0 release-blocker This bug is blocking the next release Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-mobile-platform type-bug Something isn't working

Comments

@chrisleewilcox
Copy link
Contributor

chrisleewilcox commented Apr 1, 2024 •
edited
Loading

Describe the bug

When I tap on Linea Sepolia Test Network in Select a network modal nothing happens. I am not able to switch to Linea Sepolia Test Network.
Happens on iOS and android devices.

UPDATE: app freezes on loading after upgrade if Linea Sepolia Test Network is selected prior to upgrading

Expected behavior

Tapping on a network in the Select a network modal should switch to that network that was tapped on. Doesn't work when tapping Linea Sepolia Test Network

Screenshots/Recordings

Screen.Recording.2024-04-01.at.4.53.57.PM.mov

Steps to reproduce

GIVEN I am on main Wallet view
WHEN I tap network dropdown
AND I tap Linea Sepolia Test Network
THEN wallet switches to Linea Sepolia Test Network (FAIL: wallet does not switch, nothing happens)

Error messages or log output

No response

Version

7.20.0

Build type

None

Device

Any

Operating system

iOS, Android

Additional context

No response

Severity

Sev 2
@chrisleewilcox chrisleewilcox added type-bug Something isn't working Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-mobile-platform regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-7.20.0 Issue or pull request that will be included in release 7.20.0 labels Apr 1, 2024
@chrisleewilcox chrisleewilcox added Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing release-blocker This bug is blocking the next release and removed Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking labels Apr 3, 2024
This was referenced Apr 4, 2024
Merged
Merged
chrisleewilcox pushed a commit that referenced this issue Apr 4, 2024
@tommasini
fix: Revert controller utils update (#9134)
a562cb3 
## **Description**
This reverts commit 6e87690. Can access the
[PR](#9123) here

Revert  Update controller utils to 5.0.2 

The controller util dependency of network controller v12 is on v4 and
it's not getting the patch with linea sepolia code applied, which makes
updating the controller utils dependent of network controller v13
update, for simplicity we will revert this
[PR](#9079) and then
merge it after network controller v13
[PR](#9065) is merged

## **Related issues**

Fixes: #9111

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**



https://github.com/MetaMask/metamask-mobile/assets/46944231/6e3ce0e2-ad7e-444d-b496-58822da3ad8f

Sendflow & dapp transaction



https://github.com/MetaMask/metamask-mobile/assets/46944231/38ea2ccd-b3f1-48d5-b867-00c5d7cb0507



### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding

Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@tommasini tommasini mentioned this issue Apr 8, 2024
Merged
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-7.20.0 release-7.20.0 Issue or pull request that will be included in release 7.20.0 release-blocker This bug is blocking the next release Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-mobile-platform type-bug Something isn't working
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Revert Update controller utils to 5.0.2 MetaMask/metamask-mobile
3 participants
@chrisleewilcox @sethkfman @metamaskbot