Add a viewer for outcomes #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronaldtse
requested changes
Aug 24, 2022
Gemfile.lock
Outdated
| @@ -0,0 +1,147 @@ | |||
| PATH | |||
There was a problem hiding this comment.
Let's remove Gemfile.lock
lib/bipm/data/outcomes.rb
Outdated
| module Data | ||
| module Outcomes | ||
| def self.file_path | ||
| "#{__dir__}/../../../data/" |
There was a problem hiding this comment.
We need to dynamically git fetch the bipm-data-outcomes repository (or a release) to a cache, or specify a local copy.
ronaldtse
approved these changes
Aug 30, 2022
ronaldtse
reviewed
Aug 30, 2022
| module Data | ||
| module Outcomes | ||
| def self.file_path | ||
| @file_path ||= "#{__dir__}/../../../data/" |
There was a problem hiding this comment.
The {GEM_ROOT} path may not be writable, for example, in the case in Tebako (read-only filesystem). We should use the home path as default.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #32
Metanorma PR checklist