-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIPM review: hyphen shown as em-dash #128
Comments
We just need to make sure to use whatever was in the original document that was cited. @manuel489 can you check? |
In the markup, I used a hyphen:
|
Ok so this is a bug in either MN or PDF. However, the original document uses an em dash, so we should follow that: https://www.bipm.org/documents/20126/2071204/JCGM_100_2008_E.pdf/cb0ef43f-baa5-11cf-3f85-4dcd86f77bd6 |
I see... ok. |
But still, hyphens do render as em-dashes. It seems deliberate. |
I think that has to be a bug, either in the XML or PDF. @Intelligent2013 can you check? Thanks. |
@ronaldtse looks like there is a bug (or feature) in XML. Source adoc: _Evaluation of measurement data - Guide to the expression of uncertainty in measurement_ Hex: 20(space) 2D(hyphen-minus) 20(space) MN xml: <em>Evaluation of measurement data — Guide to the expression of uncertainty in measurement</em> Hex: 2009(thin space) 2014(em dash) 2009(thin space) I've removed spaces around 2D (just for experiment) and xml contains it 'as is' <em>Evaluation of measurement data-Guide to the expression of uncertainty in measurement</em> |
This seems to be a bug in MN XML generation. Ping @opoudjis |
It is a feature and not a bug in MN XML generation, and it is deliberate. " - " is not acceptable punctuation in any style guide of English (outside of the BBC's), and is emended to be treated identically to " -- " under Asciidoctor, which converts it to " — :". I refer you to e.g. https://www.grammarly.com/blog/hyphens-and-dashes/ This behaviour of "a - b" implemented in metanorma-utils, as part of the general realisation of smart formatting. It was done because we were fetching titles from ISO with a hyphen between title components, but it was clear that ISO's intended rendering was as em-dash, as can be seen perusing any ISO document. https://www.iso.org/standard/33952.html, as you can see from the site, is Sterilization of health care products — Radiation — Part 1: Requirements for development, validation and routine control of a sterilization process for medical devices , not Sterilization of health care products - Radiation - Part 1: Requirements for development, validation and routine control of a sterilization process for medical devices, even if that is what screenscraping was intermittently returning. JCGM documents are no different to ISO documents in that regard. Realising "a -- b" as "a — b" is a canonical substitution in Asciidoctor, and realising "a - b" in the same way is consistent. To smarten quotation marks, but to leave hyphens as punctuation (!), defeats the purpose of smart quotes. If you want to reproduce the punctuation of the original in contravention of ISO style and standard punctuation practice, you can, but that should not be default Metanorma behaviour. As documented in https://www.metanorma.org/author/ref/asciidoc-tips/, interpolate a zero-width joiner: Sterilization of health care products ‌- Radiation ‌- Part 1: Requirements for development, validation and routine control of a sterilization process for medical devices https://www.metanorma.org/author/ref/asciidoc-tips/ documents the behaviour of " -- ", but does not document the parallel treatment of " - "; adding to documentation. |
I have consulted BIPM to confirm that this is a non-issue, will update. |
Confirmed with Michael Stock of BIPM:
Therefore no further action is needed. |
* main: (46 commits) Update reviewer-notes.adoc Update reviewer-notes.adoc Minor updates to GHA Update collections documentation update index on collections manifest: metanorma/metanorma-standoc#440 Update proxy post Fix HTTP proxy env var name Update blog about proxies #450 add documentation about proxies explanation of treatment of space-hyphen-space: metanorma/bipm-si-brochure#128 Use phrase “Terms and definitions” instead of “Terms & Definitions” Update to documentation on concept noref, noital concept noital, noref refactor: metanorma/metanorma-standoc#468 symbol concepts: metanorma/metanorma-standoc#488 ISO update concept/@noref, @noital: metanorma/metanorma-standoc#468 form classes: metanorma/metanorma-standoc#495 Updated docs on PDF generation correct IETF doc on published-date not revdate being used: metanorma/metanorma-ietf#157 ...
In relation to #112
From BIPM:
Original:
The text was updated successfully, but these errors were encountered: