Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIPM Feedback: French page 36, sectio 5.4.2, last side note: spaces not correct, compare with original #69

Closed
ronaldtse opened this issue Jan 1, 2021 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link
Contributor

ronaldtse commented Jan 1, 2021

This is to do with math formula variables spacing inside side notes. Notice in the sidebar the variables seem to be spaced out ("justified" spacing?).

i.e. these seem to be spaced out

  • "U_max"
  • "V_max"
  • "W(Cu)"

Original:

Screen Shot 2021-01-02 at 1 29 00 AM

Generated:

Screen Shot 2021-01-02 at 1 28 44 AM

Originally reported in #41 .

@ronaldtse ronaldtse added the bug Something isn't working label Jan 1, 2021
@Intelligent2013 Intelligent2013 added this to To do in Alexander Dyuzhev via automation Jan 2, 2021
@Intelligent2013
Copy link
Contributor

I've just rendered PDF in my environment:
изображение

max after U and V looks ok, but W(Cu) looks with spaces.

jEuclid doesn't use justification.

Original source mathml:

<math xmlns="http://www.w3.org/1998/Math/MathML">
	<mi>w</mi>
	<mfenced open="(" close=")">
		<mrow>
			<mtext>Cu</mtext>
		</mrow>
	</mfenced>
	<mo>=</mo>
	<mn>1,3</mn>
	<mo>×</mo>
	<msup>
		<mrow>
			<mn>10</mn>
		</mrow>
		<mrow>
			<mrow>
				<mo>−</mo>
				<mn>6</mn>
			</mrow>
		</mrow>
	</msup>
</math>

jEuclid renders as:
изображение

If we move mfenced open="(" close=")" into nested mtext, i.e.:

<mrow>
	<mtext>(Cu)</mtext>
</mrow>

then we get a bit compact view:
изображение

Looks like jEuclid adds some space for mfenced.

In any case isn't looks as original (there isn't distance between w and (:
изображение

In the original docx, this equation typed as normal text (not Equation object in Word). If we insert it as Equation, then we get the distance between w and (:
изображение

My proposal - move mfenced attributes into nested element in xslt on-fly.

@ronaldtse
Copy link
Contributor Author

I think the concern is about "Vmax" looking like "V m a x". The space between the parentheses is acceptable. Thanks!

Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Jan 12, 2021
@Intelligent2013
Copy link
Contributor

BIPM xslt updated for decreasing space between ( and ).
It affects on these equations: si-brochure-fr.presentation.mathml.pdf

@ronaldtse
Copy link
Contributor Author

Thank you @Intelligent2013 ! Can we close this now?

@Intelligent2013
Copy link
Contributor

Done.

Alexander Dyuzhev automation moved this from To do to Done Jan 15, 2021
@ronaldtse
Copy link
Contributor Author

Need confirmation. In the latest provided si-brochure-fr.presentation.mathml.pdf file, line 226 is this:

Screen Shot 2021-01-15 at 9 37 35 PM

BIPM pointed out that:

There is still an error in item 226: the index ‘12’ before the C for carbon, should be a superscript, not a subscript: 12C.

But it is encoded correctly in source

[stem%unnumbered]
++++
ii(M)("X") = ii(A)_"r" ("X") [ii(M)(""^{12}"C")//12] = ii(A)_"r" ("X") ii(M)_{rm(u)}
++++

And also rendered correctly in the currently released version:
Screen Shot 2021-01-15 at 9 38 23 PM

@Intelligent2013 could you help confirm the latest stylesheet is correct? Thanks!

@Intelligent2013
Copy link
Contributor

Yes, the latest stylesheet (in mn-native-pdf/xslt_src) is correct and renders so:
изображение

si-brochure-fr.presentation.mathml.pdf shows only difference between source mathml markup and mfenced processing, but not all another mathml markup as preceding superscript, superscript one-level alignment, etc.)

@ronaldtse
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants