Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF: Table header cell underlining issue in 2 MEP files #74

Closed
ronaldtse opened this issue Jan 7, 2021 · 2 comments
Closed

PDF: Table header cell underlining issue in 2 MEP files #74

ronaldtse opened this issue Jan 7, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link
Contributor

ronaldtse commented Jan 7, 2021

The table header cells seem to be have both a top line and also a bottom line, but we only want the top line if it's the first row.

  1. https://www.bipm.org/utils/common/pdf/mep/M-e-P_I2_532.pdf

https://github.com/metanorma/bipm-si-brochure/blob/master/sources/rec-values/mep-wgfs-nm532-I2.adoc

Original:
(a)
Screen Shot 2021-01-07 at 2 23 29 PM

Output:
<img width="575" alt="Screen Shot 2021-01-07 at 3 02 15 PM" src="https://user-images.githubusercontent.com/11865/103862050-58185300-50f9-11eb-9772-e8a16e67bbc9.png">

[%unnumbered]
|===
| line no | transition h| comp. 2+h| stem:[f_(xy) = [ f(y , x) – f(a_(10), R(56) 32-0) \] // rm(kHz)]
| h| stem:[x] h| stem:[y] h| stem:[f_(xy)] h| stem:[u_c // rm(kHz)]

(b)
Screen Shot 2021-01-07 at 2 23 45 PM

Output:
Screen Shot 2021-01-07 at 3 02 32 PM

[%unnumbered]
|===
| transition | comp. 2+h| stem:[f_(xy) = [ f(y , x) – f(a_(10), "R(56) 32-0") \] // " "rm(kHz)] h| Ref.
h| stem:[x] h| stem:[y] h| stem:[f_(xy)] h| stem:[u_c // rm(kHz)] h|

(c)
Screen Shot 2021-01-07 at 2 23 57 PM

Output:
Screen Shot 2021-01-07 at 3 02 52 PM

[%unnumbered]
|===
| line no | transition | comp. 6+h| stem:[[ f(y , x) – f(a_(10)," R(56) 32-0)"\] // " "rm(kHz)]
h| h| stem:[x] h| stem:[y] h| <<ye1999>> h| <<zhang>> h| <<holzwarth>> h| <<nevsky>> h| unw. mean h| stem:[u // rm(kHz)]
  1. https://www.bipm.org/utils/common/pdf/mep/M-e-P_OsO4_10.3.pdf

Original:
Screen Shot 2021-01-07 at 2 23 07 PM

Output:
Screen Shot 2021-01-07 at 3 03 39 PM

[%unnumbered]
.stem:[ii(lambda) ~~ 10.3" "mu rm(m)" OsO"_4]
|===
| h| stem:[""^12 "C"^{16} "O"_2] 2+h| stem:[rm(OsO)_4] h| | | |
h| stem:[n] h| laser line h| line h| [isotope] h| [stem:[f_n − f {R(10)}] stem:[//rm(kHz)]] h| stem:[u_c] stem:[//rm(kHz)] h| [stem:[ f (rm(OsO)_{4})] stem:[−f (rm(CO)_{2}) //rm(kHz)]] h| stem:[u_c] stem:[//rm(kHz)]
@ronaldtse ronaldtse added the bug Something isn't working label Jan 7, 2021
@Intelligent2013 Intelligent2013 added this to To do in Alexander Dyuzhev via automation Jan 7, 2021
@Intelligent2013 Intelligent2013 moved this from To do to In progress in Alexander Dyuzhev Jan 7, 2021
@Intelligent2013
Copy link
Contributor

@ronaldtse yes, you're right, for th both borders top and bootom were set. Now, only bottom. So top border for first row - is border for table, and you have to set h prefix only for cels which should have bottom border.

Issue fixed in commit metanorma/mn-native-pdf@bafe641

@Intelligent2013 Intelligent2013 moved this from In progress to Done in Alexander Dyuzhev Jan 7, 2021
@ronaldtse
Copy link
Contributor Author

This works with the latest version! Thanks!

Screen Shot 2021-01-15 at 9 57 35 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants