Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ruby-xslt dependency #22

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Remove ruby-xslt dependency #22

merged 1 commit into from
Apr 5, 2019

Conversation

CAMOBAP
Copy link
Contributor

@CAMOBAP CAMOBAP commented Apr 4, 2019

@CAMOBAP CAMOBAP self-assigned this Apr 4, 2019
@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Apr 4, 2019

@opoudjis could you please help me to understand: we use match_fuzzy but still it cares about \n (I have changed expected test output just added \n)

Maybe I did it wrong way and we ca supply extra param to match_fuzzy and it will ignore \n?

@opoudjis
Copy link
Contributor

opoudjis commented Apr 5, 2019

lib/html2doc/mathml2omml.xsl, which you deleted, is the official Microsoft XSLT; the file actually used is an earlier draft of the XSLT, which is therefore (presumably!) not subject to redistribution constraints; it was in fact redistributed by TEI. Deleting it is fine, it was a just-in-case.

@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Apr 5, 2019

@opoudjis thanks for note, anyway it will be in git history

@opoudjis
Copy link
Contributor

opoudjis commented Apr 5, 2019

https://github.com/winebarrel/rspec-match_fuzzy/blob/master/lib/rspec/match_fuzzy.rb : match fuzzy does not ignore \n completely, it just substitutes multiple consecutive \n with a single \n, and strips final \n. Your include modification has added \n between each element; that's fine, but it also isn't ignored by match_fuzzy. In any case, don't worry about it, it's fine.

@opoudjis opoudjis closed this Apr 5, 2019
@opoudjis opoudjis reopened this Apr 5, 2019
@opoudjis opoudjis merged commit 5219e1b into master Apr 5, 2019
@opoudjis opoudjis deleted the feature/remove-ruby-xslt branch April 5, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants