Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(URGENT) Fix hiding of CGPM/CIPM tag references #171

Closed
manuelfuenmayor opened this issue May 31, 2022 · 2 comments
Closed

(URGENT) Fix hiding of CGPM/CIPM tag references #171

manuelfuenmayor opened this issue May 31, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@manuelfuenmayor
Copy link

manuelfuenmayor commented May 31, 2022

In relation to metanorma/bipm-si-brochure#145

CGPM/CIPM reference tags are not being hidden.

Maybe this line from 722995e has to do with the problem:

return true if /^BIPM CGPM Resolution|^BIPM CIPM Decision/.match?(b&.text)

CGPM/CIPM identifiers are no longer starting with "BIPM".

In addition, we need to take into account two more types of outcomes:
"Recommendation" and "Declaration".

Some identifier examples:

CGPM Resolution 2011-01
CIPM Resolution 02 (1946)
CIPM Recommendation (1961)
CIPM Recommendation 2 (1967)
CIPM Declaration (1964)
CIPM Declaration 1 (2001)
CIPM Decision 2017-10
CCDS Recommendation 2 (1970)

CCDS is another body that we need to include besides CGPM/CIPM.
And judging for this piece of message:

"For the CCDS Recommendation 2 (1970) the link is https://www.bipm.org/en/committees/cc/cctf/5-1970/resolution-2, but the committee at that time was called CCDS, not CCTF."
(from #164)

Maybe we should include CCTF as well.

@ronaldtse ronaldtse changed the title Fix hiding of CGPM/CIPM tag references (URGENT) Fix hiding of CGPM/CIPM tag references May 31, 2022
@ronaldtse ronaldtse transferred this issue from metanorma/isodoc May 31, 2022
@ronaldtse ronaldtse added the bug Something isn't working label May 31, 2022
@ronaldtse
Copy link
Contributor

Maybe we should include CCTF as well.

Yes.

I think the code for skipping references should possibly reside in metanorma-bipm because we don't need to skip BIPM references if used in other flavors.

@opoudjis
Copy link
Contributor

It does. Actioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants