Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIPM review on document layout for "mise en pratique" #32

Closed
ronaldtse opened this issue Oct 20, 2020 · 13 comments
Closed

BIPM review on document layout for "mise en pratique" #32

ronaldtse opened this issue Oct 20, 2020 · 13 comments
Assignees
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link
Contributor

ronaldtse commented Oct 20, 2020

From BIPM:

In the mise en pratique for the ampere I observed the following:

I believe the title page titles are encoded in the sample document as document attributes. @manuel489 can you help update the mise en pratiques? Thanks.

UPDATE: all issues should have been addressed.

@manuelfuenmayor
Copy link

I believe the title page titles are encoded in the sample document as document attributes. @manuel489 can you help update the mise en pratiques? Thanks.

Sure, PR link is shown above.

@ronaldtse
Copy link
Contributor Author

Thanks @manuel489 !

@Intelligent2013
Copy link
Contributor

"1. Edition 2019" should be replaced with "9. Edition 2019", also on page 3

Need to source data fix.

Each section starts on a new page, which is strange when the sections are as short as in this document.

I'll add section text length check.

The symbol for the elementary charge “e” should always be italicized.
In numbers with many digits, they should be grouped by three for better readability:
page 5: 1.602176634 -> 1.602 176 636
page 7: 483597.848416984 -> 483 597.848 416 984

Need to source data fix.

The spaces need to be protected against line-breaks

What does mean?

Page 6: in the original text, lists were not numbered but had letters (a), (b), (c), …

Need to source data fix.

References to “sections” have become references to “clauses”
References to “equations” have become references to “formulas”

Need to source data fix.

Pages 8 and 16: Wrong font size in the header

Done in metanorma/mn-native-pdf#269

Page 17: “References” have become “Bibliography”.

Need to source data fix.

@manuelfuenmayor
Copy link

@Intelligent2013, ok. I'm taking care of the source data fix parts...

@manuelfuenmayor
Copy link

"1. Edition 2019" should be replaced with "9. Edition 2019", also on page 3

Fixed by markup in PR above.

The symbol for the elementary charge “e” should always be italicized.
In numbers with many digits, they should be grouped by three for better readability:
page 5: 1.602176634 -> 1.602 176 636
page 7: 483597.848416984 -> 483 597.848 416 984

Fixed by markup in PR above.

@manuelfuenmayor
Copy link

Page 6: in the original text, lists were not numbered but had letters (a), (b), (c), …

I don't understand this issue. The lists in mise en pratique for ampere output are ordered by letters like: "a.", "b.", "c.", etc. If they should render as "(a)", "(b)", ... , then I believe it's not fixable by markup.

References to “sections” have become references to “clauses”
References to “equations” have become references to “formulas”

I believe this is not fixable by markup.

Page 17: “References” have become “Bibliography”.

I believe this is not fixable by markup.

@opoudjis opoudjis added this to Current in Nick Nicholas Oct 22, 2020
@opoudjis
Copy link
Contributor

I don't understand this issue. The lists in mise en pratique for ampere output are ordered by letters like: "a.", "b.", "c.", etc. If they should render as "(a)", "(b)", ... , then I believe it's not fixable by markup.

Note that I shall refuse, with extreme vehemence, to allow individual documents to change list markup from "a." to "(a)" or "a)" or "---->a", and I have been saying so in tickets. Such muddle-headed inconsistency between documents is a bug and not a feature, and I will not do anything to perpetuate it. That's what Metanorma is for: to impose consistency.

References to “sections” have become references to “clauses”
References to “equations” have become references to “formulas”

BIPM need to provide assurance that all sections in BIPM publications are referred to as clauses, and all formulas are referred to as equations (or possibly inequations). I am not going to do document-specific fixes: that is not what Metanorma is for.

Page 17: “References” have become “Bibliography”.

Again, need to ensure that is consistent practice: Metanorma imposes uniform clause titles.

I will investigate documents on BIPM site to see what the patterns are. But as I have said repeatedly, BIPM are NOT going to get solutions specific to a document.

@Intelligent2013
Copy link
Contributor

Each section starts on a new page, which is strange when the sections are as short as in this document.

  1. I will display sections for MEP without page breaks, but in this case I have to change the header to 'Appendix X' instead of '
    ', because jEuclid can't set font-size and font-name property via retrieve-marker mechanism.
  2. If need pagebreak between concrete section, then put <<< to <pagebreak/>

Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Oct 22, 2020
Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Oct 22, 2020
Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Oct 22, 2020
@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Oct 22, 2020

  • “’Mise en pratique” should always be italicized in English text.

Done. Changed for titles displaying in xslt.

  • Each section starts on a new page, which is strange when the sections are as short as in this document.

Done.

  • Page 6: in the original text, lists were not numbered but had letters (a), (b), (c), …

Done. The rule for 'alphabet' lists changed from a) to (a) for appendixes.

@ronaldtse
Copy link
Contributor Author

From @Intelligent2013

In the source PDF, the French part on page 72 (section Révision de la mise en pratique de la définition du mètre (PV, 70, 90-101 et Metrologia, 40, 103-133)) uses:
a)...
b)
c)

However, in the English part, page 181 (Revision of the practical realization of the definition of the metre (PV, 70, 194-204 and Metrologia, 40, 103-133) uses:
(a)
(b)
(c)

And there are:

Screen Shot 2020-10-24 at 1 11 25 AM

And
Screen Shot 2020-10-24 at 1 13 40 AM

Asked BIPM to see if they can accept a unified numbered list style.

@ronaldtse
Copy link
Contributor Author

Each section starts on a new page, which is strange when the sections are as short as in this document.

  1. I will display sections for MEP without page breaks, but in this case I have to change the header to 'Appendix X' instead of '', because jEuclid can't set font-size and font-name property via retrieve-marker mechanism.
  2. If need pagebreak between concrete section, then put <<< to <pagebreak/>

This is addressed in #48, we will start a new page per section for consistency.

@ronaldtse
Copy link
Contributor Author

Note that I shall refuse, with extreme vehemence, to allow individual documents to change list markup from "a." to "(a)" or "a)" or "---->a", and I have been saying so in tickets. Such muddle-headed inconsistency between documents is a bug and not a feature, and I will not do anything to perpetuate it. That's what Metanorma is for: to impose consistency.

This is addressed in #47 , we will use "1." then "a)" as agreed with BIPM across all documents.

References to “sections” have become references to “clauses”
References to “equations” have become references to “formulas”
Page 17: “References” have become “Bibliography”.

BIPM need to provide assurance that all sections in BIPM publications are referred to as clauses, and all formulas are referred to as equations (or possibly inequations). I am not going to do document-specific fixes: that is not what Metanorma is for.

I have confirmed in existing documents (SI Brochure, MEPs) that BIPM uses the following referential conventions:

  • "Section X.X" or "section X.X" for clauses
  • "Equation (n)" or "equation (n)" for formulas
  • "References" as the section title for the bibliography.

We will implement these.

@opoudjis
Copy link
Contributor

All issues raised addressed.

Nick Nicholas automation moved this from On hold to Closed Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Nick Nicholas
  
Closed
Development

No branches or pull requests

4 participants