Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate 2024 PDF layout using production standard #1134

Closed
ronaldtse opened this issue Mar 15, 2024 · 20 comments
Closed

Validate 2024 PDF layout using production standard #1134

ronaldtse opened this issue Mar 15, 2024 · 20 comments
Assignees

Comments

@ronaldtse
Copy link
Contributor

We need to validate our implementation of the 2024 layout against a production standard:

This is a private copy.

@Intelligent2013
Copy link
Contributor

Our implementation of the 2024 layout looks differently:

  • page margins

    • rendered PDF
      image

    • production standard
      image

  • header font-size

    • rendered PDF (0.5pt smaller font)
      image

    • production standard
      image

  • copyright font-size

    • rendered PDF
      image

    • production standard
      image

  • main text font-size

    • rendered PDF
      image

    • production standard
      image

  • last page footer

    • rendered PDF
      image

    • production standard
      image

Our PDF layout was updated in #1079 based on the provided PDF example 2024-iso-new-pdf-layout.pdf "Sample of layout for an International Standard (cover page, back page and internal centered layout)".

@ronaldtse to further actions I have to know exactly - what is the correct PDF - in this issue or in #1079?

Note: the PDF from the initial posts opens in the Chrome browser only. Adobe Acrobat opens it and closes immediately, also Foxit Reader and PDF-XChange Viewer. So I have to repair it somehow.

@ronaldtse
Copy link
Contributor Author

Adobe Acrobat opens it and closes immediately

I'm seeing the same issue too. I can open it in macOS Preview however.

It is very likely that their "design spec" and implemented production PDF are slightly different.

@Intelligent2013
Copy link
Contributor

  • blue email vs. www link:
    • rendered PDF:
      image

    • production standard:
      image

The last link points to https://www.iso.org/.

From metanorma-iso gem boilerplate.adoc:

[[boilerplate-address]]
[align=left]
ISO copyright office +
CP 401 • Ch. de Blandonnet 8 +
CH-1214 Vernier, Geneva +
Phone: +41 22 749 01 11 +
Email: copyright@iso.org +
Website: www.iso.org

Presentation XML:

	<p id="boilerplate-address" align="left">ISO copyright office<br/>
CP 401 • Ch. de Blandonnet 8<br/>
CH-1214 Vernier, Geneva<br/>
Phone: +41 22 749 01 11<br/>
Email: <link target="mailto:copyright@iso.org"/>
		<br/>
Website: www.iso.org</p>
				...
		</copyright-statement>

copyright@iso.org automatically converts to <link target="mailto:copyright@iso.org"/>, but www.iso.org doesn't.
I need update boilerplate.adoc

@Intelligent2013
Copy link
Contributor

To check the whole document I'll encode it in adoc.

@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Mar 19, 2024

  • one numbered Note
    • rendered PDF:
      image

    • production PDF:
      image

The rendered PDF is correct. From https://www.iso.org/sites/directives/current/part2/index.xhtml#_idTextAnchor340:

24.3 Numbering and subdivision
Within a given clause or subclause, notes shall be numbered sequentially. The numbering restarts at each new subdivision. A single note in a subdivision shall not be numbered.

  • ordered list numbering - alphabetic vs. arabic:
    • rendered PDF:
      image

    • production PDF:
      image

From https://www.metanorma.org/author/topics/blocks/lists/#general-2:
image

  • different font size of Note: no difference, just PDF viewer approximation.

    • rendered PDF (a bit smaller):
      image
    • production PDF:
      image
  • wrong baseline when list text contains superscripted text

    • rendered PDF:
      image
  • there isn't footnotes separator (51mm horizontal line) in the rendered PDF

  • indents between footnotes:

    • rendered PDF:
      image
    • production PDF:
      image

@Intelligent2013
Copy link
Contributor

There is the identical entry in the Normative references and Bibliography:
image

image

therefore different identifiers should be used in the adoc:

[bibliography]
== Normative references

* [[[ISO19103,ISO 19103]]], _Geographic information -- Conceptual schema language_
...


[bibliography]
== Bibliography

* [[[ISO19103bib,ISO 19103]]], _Geographic information -- Conceptual schema language_
,..

@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Mar 19, 2024

  • Source color link:

    • rendered PDF:
      image

    • production PDF:
      image

  • Example (numbered vs. unnumbered) alignment:

    • rendered PDF:
      image

    • production PDF:
      image

Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Mar 19, 2024
@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Mar 19, 2024

  • dash after modified:
    • rendered PDF en dash (U+2013):
      image
    • production PDF em dash (U+2014):
      image

Presentation XML contains en dash:

</xref>, modified
 – Note 1 to entry removed.]</termsource>

@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Mar 19, 2024

  • different vertical indents between the definition list items, need increase a bit

Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Mar 19, 2024
@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Mar 19, 2024

  • text with indent
    • rendered PDF:
      image
    • production PDF:
      image

Note: I don't know how to achieve it.

  • space before table name

    • rendered PDF:
      image

    • production PDF:
      image

  • table footer top border

  • space between footnotes

    • rendered PDF
      image
    • production PDF
      image
  • space after table

    • rendered PDF:
      image

    • production PDF:
      image

Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Mar 20, 2024
Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Mar 20, 2024
@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Mar 20, 2024

  • reference from Annex A sub-clause to another sub-clause

    • rendered PDF:
      image
    • production PDF:
      image
  • reference from Annex A sub-clause to main section sub-clause

    • rendered PDF
      image
    • production PDF
      image

@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Mar 20, 2024

  • table cell borders
    • rendered PDF:
      image

    • production PDF:
      image

@ronaldtse
Copy link
Contributor Author

@Intelligent2013 can you help file issues for @opoudjis for those he needs to fix? Thanks.

opoudjis added a commit that referenced this issue Mar 21, 2024
copyright statement boilerplate updated for layout 2024, #1134
@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Mar 21, 2024

  • smallcap font-size
    • rendered PDF
      image

    • production PDF
      image

Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Mar 21, 2024
@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Mar 21, 2024

  • references to the Bibliography items
    • rendered PDF:
      image
    • production PDF
      image

@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Mar 21, 2024

  • comma between bibliography references
    • rendered PDF:
      image
    • production PDF:
      image

Adoc markup:

<<ref10>>,<<ref15>>

This was referenced Mar 21, 2024
@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Mar 21, 2024

  • text with indent
    • rendered PDF:
      image
    • production PDF:
      image

This issue can be solved via css: [css text-indent:7mm]#*1) CoreClassConformant*#.
Rendered PDF:
image

@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Mar 22, 2024

  • reference to the standard
    • rendered PDF
      image
    • production PDF
      image

@Intelligent2013
Copy link
Contributor

ISO XSLT updated for PDF layout 2024.
Only one issue remains: #1141
On hold.

@Intelligent2013
Copy link
Contributor

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants