refactor logging: metanorma/metanorma-iso#1065

metanorma · Dec 8, 2023 · c9a9d39 · c9a9d39
1 parent 482f9af
commit c9a9d39
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/Gemfile b/Gemfile
@@ -4,8 +4,12 @@ Encoding.default_internal = Encoding::UTF_8
 source "https://rubygems.org"
 git_source(:github) { |repo| "https://github.com/#{repo}" }
 
-gemspec
+group :development, :test do
+  gem "rspec"
+end
 
 if File.exist? "Gemfile.devel"
   eval File.read("Gemfile.devel"), nil, "Gemfile.devel" # rubocop:disable Security/Eval
 end
+
+gemspec
diff --git a/lib/metanorma/modspec/validate.rb b/lib/metanorma/modspec/validate.rb
@@ -4,12 +4,10 @@ module Metanorma
   class Requirements
     class Modspec < Default
       def validate(reqt, log)
-        @fatalerrors = []
         @log ||= log
         @ids ||= reqt_links(reqt.document)
         reqt_cycles_validate
         reqt_link_validate(reqt)
-        @fatalerrors
       end
 
       def nested_reqt?(reqt)
@@ -130,8 +128,7 @@ def reqt_links1_label(reqt, hash, struct)
 
         if hash[:label][struct[:label]]
           msg = "Modspec identifier #{struct[:label]} is used more than once"
-          @log.add("Requirements", reqt, msg)
-          @fatalerrors << msg
+          @log.add("Requirements", reqt, msg, severity: 0)
         end
         hash[:label][struct[:label]] = reqt["id"]
         hash