We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
token-metadata
Rust Contract
For https://formfunction.xyz/@degenpoet/F5smPCKim7iDQQGL3kGA2mtJDaA5wd2E18Vqa5nbJbHD?width=3000&height=4000, you can see that edition #70 was successfully minted, even though the max supply is 69
AFAICT it's a bug with this code https://github.com/metaplex-foundation/metaplex-program-library/blame/master/token-metadata/program/src/utils.rs#L554-L572
Let's say max_supply = 69 and current_supply = 69
max_supply = 69
current_supply = 69
Then, new_supply = 69, which is not > max, and so MaxEditionsMintedAlready will never be hit
new_supply = 69
> max
MaxEditionsMintedAlready
No response
High (immediate attention needed)
The text was updated successfully, but these errors were encountered:
Resolved. Thank you for bringing this to our attention. Follow up here if the issue seems to NOT be resolved!
Sorry, something went wrong.
@roederw thanks! Do you mind linking to the PR/commit that fixed this?
#779
Merge pull request metaplex-foundation#776 from arcNFT/our-4000-mistake
73af080
Fix float and integer check for metaplex share allocation
No branches or pull requests
Which package is this bug report for?
token-metadata
Which Type of Package is this bug report for?
Rust Contract
Issue description
For https://formfunction.xyz/@degenpoet/F5smPCKim7iDQQGL3kGA2mtJDaA5wd2E18Vqa5nbJbHD?width=3000&height=4000, you can see that edition #70 was successfully minted, even though the max supply is 69
AFAICT it's a bug with this code https://github.com/metaplex-foundation/metaplex-program-library/blame/master/token-metadata/program/src/utils.rs#L554-L572
Let's say
max_supply = 69
andcurrent_supply = 69
Then,
new_supply = 69
, which is not> max
, and soMaxEditionsMintedAlready
will never be hitRelevant log output
No response
Priority this issue should have
High (immediate attention needed)
The text was updated successfully, but these errors were encountered: