Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Edition #70 was minted for a master edition with max supply #69 #776

Closed
arcticmatt opened this issue Sep 29, 2022 · 3 comments
Closed
Labels

Comments

@arcticmatt
Copy link

Which package is this bug report for?

token-metadata

Which Type of Package is this bug report for?

Rust Contract

Issue description

For https://formfunction.xyz/@degenpoet/F5smPCKim7iDQQGL3kGA2mtJDaA5wd2E18Vqa5nbJbHD?width=3000&height=4000, you can see that edition #70 was successfully minted, even though the max supply is 69

AFAICT it's a bug with this code https://github.com/metaplex-foundation/metaplex-program-library/blame/master/token-metadata/program/src/utils.rs#L554-L572

Let's say max_supply = 69 and current_supply = 69

Then, new_supply = 69, which is not > max, and so MaxEditionsMintedAlready will never be hit

Relevant log output

No response

Priority this issue should have

High (immediate attention needed)

@arcticmatt arcticmatt added the bug label Sep 29, 2022
@roederw
Copy link
Contributor

roederw commented Sep 29, 2022

Resolved. Thank you for bringing this to our attention. Follow up here if the issue seems to NOT be resolved!

@roederw roederw closed this as completed Sep 29, 2022
@arcticmatt
Copy link
Author

@roederw thanks! Do you mind linking to the PR/commit that fixed this?

@samuelvanderwaal
Copy link
Contributor

@roederw thanks! Do you mind linking to the PR/commit that fixed this?

#779

KirillLykov pushed a commit to KirillLykov/metaplex-program-library that referenced this issue Jul 4, 2023
Fix float and integer check for metaplex share allocation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants