Skip Uint8Arrays on unwrapOptionRecursively (#84)

metaplex-foundation · Aug 25, 2023 · 05a4bdd · 05a4bdd
1 parent e5a1385
commit 05a4bdd
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/.changeset/rich-otters-rhyme.md b/.changeset/rich-otters-rhyme.md
@@ -0,0 +1,5 @@
+---
+'@metaplex-foundation/umi-options': patch
+---
+
+Skip Uint8Arrays on unwrapOptionRecursively
diff --git a/packages/umi-options/src/unwrapOptionRecursively.ts b/packages/umi-options/src/unwrapOptionRecursively.ts
@@ -50,8 +50,11 @@ export function unwrapOptionRecursively<T, U = null>(
   input: T,
   fallback?: () => U
 ): UnwrappedOption<T, U> {
-  // Because null passes `typeof input === 'object'`.
-  if (!input) return input as UnwrappedOption<T, U>;
+  // Types to bypass.
+  if (!input || ArrayBuffer.isView(input)) {
+    return input as UnwrappedOption<T, U>;
+  }
+
   const next = <X>(x: X) =>
     (fallback
       ? unwrapOptionRecursively(x, fallback)

diff --git a/packages/umi-options/test/unwrapOptionRecursively.test.ts b/packages/umi-options/test/unwrapOptionRecursively.test.ts
@@ -24,6 +24,12 @@ test('it can unwrap options recursively', (t) => {
   t.is(unwrapOptionRecursively(null), null);
   t.is(unwrapOptionRecursively(undefined), undefined);
 
+  // TypedArrays.
+  t.deepEqual(
+    unwrapOptionRecursively(new Uint8Array([1, 2, 3])),
+    new Uint8Array([1, 2, 3])
+  );
+
   // Functions.
   const fn = () => 42;
   t.is(unwrapOptionRecursively(fn), fn);