Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed rentEpoch type in AccountHeader from number to BigInt #105

Merged
merged 5 commits into from
Jan 6, 2024

Conversation

HarishPrasannaV
Copy link
Contributor

Addressed issue #99

  • I ran unit tests, and it worked. (please don't get mad if I messed up, I'm still a noob)

Copy link

changeset-bot bot commented Jan 5, 2024

🦋 Changeset detected

Latest commit: 52f1fd9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@metaplex-foundation/umi-rpc-web3js Major
@metaplex-foundation/umi Major
@metaplex-foundation/umi-bundle-defaults Major
@metaplex-foundation/umi-bundle-tests Major
@metaplex-foundation/umi-uploader-bundlr Major
@metaplex-foundation/umi-uploader-irys Major
@metaplex-foundation/umi-uploader-nft-storage Major
@metaplex-foundation/umi-downloader-http Major
@metaplex-foundation/umi-eddsa-web3js Major
@metaplex-foundation/umi-http-fetch Major
@metaplex-foundation/umi-program-repository Major
@metaplex-foundation/umi-rpc-chunk-get-accounts Major
@metaplex-foundation/umi-serializer-beet Major
@metaplex-foundation/umi-serializer-data-view Major
@metaplex-foundation/umi-signer-derived Major
@metaplex-foundation/umi-signer-wallet-adapters Major
@metaplex-foundation/umi-storage-mock Major
@metaplex-foundation/umi-transaction-factory-web3js Major
@metaplex-foundation/umi-uploader-aws Major
@metaplex-foundation/umi-web3js-adapters Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@HarishPrasannaV
Copy link
Contributor Author

Umm...I don't understand why it failed the first test.
It passed on the first commit??????

@HarishPrasannaV
Copy link
Contributor Author

INPUT_BRANCH value: issue_99_fix
Should I merge the branch with main and then give pull request again?

@lorisleiva
Copy link
Collaborator

It's a linting problem. If you run pnpn lint:fix && pnpn format:fix then commit the result, it should be happy.

Copy link
Collaborator

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lorisleiva lorisleiva merged commit 703bace into metaplex-foundation:main Jan 6, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants