Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ECMAScript 2018 BigInt in parser #35

Closed
o-rumiantsev opened this issue Sep 11, 2018 · 1 comment
Closed

Use ECMAScript 2018 BigInt in parser #35

o-rumiantsev opened this issue Sep 11, 2018 · 1 comment
Assignees

Comments

@o-rumiantsev
Copy link
Member

As parcel.length property has size of 8 bytes, we can store it using bigint type, and in buffer it will be represented like two int32

@o-rumiantsev o-rumiantsev self-assigned this Sep 11, 2018
o-rumiantsev added a commit to Tariod/metacom that referenced this issue Sep 12, 2018
o-rumiantsev added a commit to Tariod/metacom that referenced this issue Sep 12, 2018
o-rumiantsev added a commit to Tariod/metacom that referenced this issue Sep 12, 2018
o-rumiantsev pushed a commit to Tariod/metacom that referenced this issue Nov 26, 2018
* node version to ^10.0.0
* use bigint, PR-URL: metarhia#35
* tests for parser, bigint-buffer

Closes: metarhia#3
o-rumiantsev pushed a commit to Tariod/metacom that referenced this issue Sep 20, 2019
* node version to ^10.0.0
* use bigint, PR-URL: metarhia#35
* tests for parser, bigint-buffer

Closes: metarhia#3
@tshemsedinov
Copy link
Member

Closed in favour of new version 0.1.x implementing new specification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants