Add contracts for parser functions #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/parser.js
Outdated
| // Read parcel from buffer | ||
| // Return parcel object | ||
| const rest = Buffer.from(buffer, 1, PARCEL_LENGTH); | ||
| return rest; | ||
| }; | ||
|
|
||
| const chunk = (buffer) => { | ||
| const parcel = ( | ||
| // Encode handshake structure to Buffer |
There was a problem hiding this comment.
Encode parcel structure скорее
mille-nium
reviewed
Apr 24, 2018
| @@ -1,41 +1,86 @@ | |||
| 'use strict'; | |||
|
|
|||
| const PROTOCOL_VERSION = 1; | |||
There was a problem hiding this comment.
In issue #3 2b for protocol version declared
There was a problem hiding this comment.
We will use writeInt16LE to write this Number value to 2 bytes binary field @mille-nium
Tariod
approved these changes
Apr 26, 2018
tshemsedinov
added a commit
that referenced
this pull request
May 22, 2018
|
Landed in 4d26244 |
o-rumiantsev
pushed a commit
to o-rumiantsev/metacom
that referenced
this pull request
May 22, 2018
tshemsedinov
added a commit
that referenced
this pull request
Jun 4, 2018
o-rumiantsev
pushed a commit
that referenced
this pull request
Jul 16, 2018
dimanadko
pushed a commit
to dimanadko/metacom
that referenced
this pull request
Jul 24, 2018
dimanadko
pushed a commit
to Tariod/metacom
that referenced
this pull request
Jul 31, 2018
dimanadko
pushed a commit
to Tariod/metacom
that referenced
this pull request
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.