-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contracts for parser functions #12
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,41 +1,86 @@ | ||
'use strict'; | ||
|
||
const PROTOCOL_VERSION = 1; | ||
const HANDSHAKE_LENGTH = 36; | ||
const PARCEL_LENGTH = 16; | ||
const CHUNK_LENGTH = 12; | ||
|
||
const parcel = (buffer) => { | ||
const readParcel = (buffer) => { | ||
// Read parcel from buffer | ||
// Return parcel object | ||
const rest = Buffer.from(buffer, 1, PARCEL_LENGTH); | ||
return rest; | ||
}; | ||
|
||
const chunk = (buffer) => { | ||
const parcel = ( | ||
// Encode parcel structure to Buffer | ||
// id, // parcelId: 4b | ||
// type, // parcelType: 4b | ||
// compression, // 1b: no = 0, gzip = 1 | ||
// encoding, // 1b: binary = 0, jstp = 1, json = 2, bson = 3, v8 = 4 | ||
// length // 8b | ||
) => { | ||
const parcel = Buffer.alloc(PARCEL_LENGTH); | ||
parcel.writeInt8(0, 0); | ||
// Write parcel fields to buffer | ||
return parcel; | ||
}; | ||
|
||
const readChunk = (buffer) => { | ||
// Read chunkk from buffer | ||
// Return chunk object | ||
const rest = Buffer.from(buffer, 1, CHUNK_LENGTH); | ||
return rest; | ||
}; | ||
|
||
const handshake = (buffer) => { | ||
const chunk = ( | ||
// Encode chunk structure to Buffer | ||
// id, // parcelId: 4b | ||
// flags, // 1b: more = 1, stop = 2, pause = 4, resume = 8 | ||
// length, // 2b | ||
// payload // Buffer | ||
) => { | ||
const chunk = Buffer.alloc(CHUNK_LENGTH); | ||
chunk.writeInt8(1, 0); | ||
// Write chunk fields to buffer | ||
return chunk; | ||
}; | ||
|
||
const readHandshake = (buffer) => { | ||
// Read handshake from buffer | ||
// Return handshake object | ||
const rest = Buffer.from(buffer, 0, HANDSHAKE_LENGTH); | ||
return rest; | ||
}; | ||
|
||
const handshake = ( | ||
// Encode handshake structure to Buffer | ||
// status // 1b: 0 = new, 1 = restore | ||
// reserved // 1b | ||
// token // 32b (optional) | ||
) => { | ||
const handshake = Buffer.alloc(HANDSHAKE_LENGTH); | ||
handshake.writeInt16LE(PROTOCOL_VERSION, 0); | ||
// Write handshake to buffer | ||
return handshake; | ||
}; | ||
|
||
const structTypes = [ | ||
/* 0 */ parcel, | ||
/* 1 */ chunk | ||
/* 0 */ readParcel, | ||
/* 1 */ readChunk | ||
]; | ||
|
||
const structure = (buffer) => { | ||
const readStruct = (buffer) => { | ||
// Read structure from buffer | ||
// Return parcel or chunk object | ||
const structType = buffer.readInt8(0, true); | ||
const parser = structTypes[structType]; | ||
if (parser) return parser(buffer); | ||
}; | ||
|
||
module.exports = { structure, handshake, chunk, parcel }; | ||
module.exports = { | ||
handshake, readHandshake, | ||
chunk, readChunk, | ||
parcel, readParcel, | ||
readStruct | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In issue #3 2b for protocol version declared
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will use
writeInt16LE
to write thisNumber
value to 2 bytes binary field @mille-nium