Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1 line shift in stack traces #102

Closed
wants to merge 3 commits into from
Closed

Fix 1 line shift in stack traces #102

wants to merge 3 commits into from

Conversation

tshemsedinov
Copy link
Member

  • tests and linter show no problems (npm t)
  • tests are added/updated for bug fixes and new features
  • code is properly formatted (npm run fmt)
  • description of changes is added in CHANGELOG.md

tshemsedinov added a commit that referenced this pull request Mar 10, 2023
@tshemsedinov
Move constants to place of use
9d47e9b 
PR-URL: #102
tshemsedinov added a commit that referenced this pull request Mar 10, 2023
@tshemsedinov
Fix 1 line shift in stack traces
9a88bff 
PR-URL: #102
tshemsedinov added a commit that referenced this pull request Mar 10, 2023
@tshemsedinov
Add tests for line numbers in stack traces
ef15cbc 
PR-URL: #102
@tshemsedinov
Copy link
Member Author

Landed in 9d47e9b, 9a88bff, and ef15cbc

@tshemsedinov tshemsedinov deleted the fix-line branch March 10, 2023 19:33
@a-mountain a-mountain mentioned this pull request Apr 29, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tshemsedinov