Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Permission change active without server cache reset #366

Closed
metasnw opened this issue May 11, 2017 · 2 comments
Closed

Make Permission change active without server cache reset #366

metasnw opened this issue May 11, 2017 · 2 comments

Comments

@metasnw
Copy link
Member

metasnw commented May 11, 2017

Is this a bug or feature request?

feature

What is the current behavior?

after changing permissions you have to reset server cache which only can be done by admin and requires one extra step

Which are the steps to reproduce?

  1. change permission
  2. follow: http://docs.metasfresh.org/installation_collection/EN/How_to_reset_server_cache.html

What is the expected or desired behavior?

If a permission is changed (e.g. grant/revoke access to some window) it shall be propagated automatically without any cache reset.
The cache invalidation shall be distributed.
e.g. Edit permissions on Swing, they shall be automatically propagated to webui server

teosarca added a commit to metasfresh/metasfresh that referenced this issue May 14, 2017
teosarca added a commit to metasfresh/metasfresh that referenced this issue May 14, 2017
teosarca added a commit to metasfresh/metasfresh that referenced this issue May 14, 2017
teosarca added a commit to metasfresh/metasfresh that referenced this issue May 14, 2017
teosarca added a commit to metasfresh/metasfresh that referenced this issue May 14, 2017
* introduced opt. params: p_AD_Role_ID, p_CreatedBy
* refactored
* handle AD_Document_Action_Access too

metasfresh/metasfresh-webui-api-legacy#366
teosarca added a commit to metasfresh/metasfresh that referenced this issue May 14, 2017
teosarca added a commit to metasfresh/metasfresh that referenced this issue May 14, 2017
teosarca added a commit to metasfresh/metasfresh that referenced this issue May 14, 2017
* All Accesses retrieval shall be done via IUserRolePermissionsDAO
* get rid of M*Access classes
* propagate permissions cache reset accross nodes

metasfresh/metasfresh-webui-api-legacy#366
teosarca added a commit to metasfresh/metasfresh that referenced this issue May 14, 2017
teosarca added a commit to metasfresh/metasfresh that referenced this issue May 14, 2017
@teosarca
Copy link
Member

Note to IT:

  • full regression test on permissions, also try different roles
  • full regression test on permissions requests (grand and revoke)
  • try changing permissions in Swing and expect them to be instantly updated on webui. e.g.
    ** webui: open a window
    ** swing: deactivate the permissions for that window
    ** webui: refresh page => "No access" error shall popup
    ** swing: activate the permissions for that window
    ** webui: refresh page => you shall get back your page

@teosarca teosarca added this to the 2017-20 milestone May 14, 2017
@metas-lc metas-lc self-assigned this May 16, 2017
@metas-lc
Copy link

metas-lc commented May 16, 2017

IT

  1. roles
  • logged in with different roles => depending on what permissions they had, you could or couldn't access a window OK
  • (also checked this testcase:
  1. permission requests:
  • created new role, similar with Admin and made Sales Order (ad_window_access) inactive.
    => webui: could still see it in Menu (NOK will be solved in: menu is not updating when you change permission #382 )
    => swing: not visible in menu OK

  • Open sales order page in webui (using link directly)
    => error: no access OK

  • In swing, go to last 2 tabs:
    => there is a new entry in each, saying that you don't have permissions for this role on sales order

  • Press on grant permission button and on read write say NO
    => AD_Window_Access for sales order is Active and read write is on No

  • Open sales order in swing and webui
    => webui: you can add new/ edit NOK (will be solved in: readonly permission in webui #380)
    => swing: readonly: cannot add new or modify OK

  • Go back to Permission request subtab and press again on grant permission, read write on Y
    => AD_Window_Access for sales order is Active and read write is on Yes
    => webui: you can add new/ edit OK
    => swing: you can add new/ edit OK

  • Go back to permissions request subtab and press on Revoke permission
    => AD_Window_Access for sales order is deleted
    => webui: (here i used logout/login this time) Sales order is in menu NOK (will be solved in: menu is not updating when you change permission #382)
    => swing: Sales order is missing from menu OK

  • Go back to permissions request subtab and press on grant permission
    => AD_Window_Access for sales order is added back
    => webui: (here i used logout/login this time) Sales order is in menu OK
    => swing: Sales order is in menu OK

  • note: on swing you have to logout/login to see the changes. On webui is working directly - just refresh the page OK

metas-ts added a commit to metasfresh/metasfresh that referenced this issue May 18, 2017
[#743](metasfresh/metasfresh-webui-frontend-legacy#743) modal panel: background looks a bit ugly
[#377](metasfresh/metasfresh-webui-api-legacy#377) Don't show zoom-to for non-zoom reference Lists
[#366](metasfresh/metasfresh-webui-api-legacy#366) Make Permission change active without server cache reset
[#372](metasfresh/metasfresh-webui-api-legacy#372) backend: endpoint for creating a filtered view
[#1521](#1521) standard database: add SSCC attribute to "DIM_Barcode_Attributes" dimension spec
[#1517](#1517) intern: refactor LanguageDAO and LanguageBL
[#369](metasfresh/metasfresh-webui-api-legacy#369) adding role to user does not work
[#679](metasfresh/metasfresh-webui-frontend-legacy#679) Record selection behavior w/ browser back/ forward
[#707](metasfresh/metasfresh-webui-frontend-legacy#707) Page popup shall be closed when clicking o a page
[#715](metasfresh/metasfresh-webui-frontend-legacy#715) KPI widgets shall have the same height
[#732](metasfresh/metasfresh-webui-frontend-legacy#732) issue not opening on single document
[#734](metasfresh/metasfresh-webui-frontend-legacy#734) included view: don't reset when closing an error notification
[#362](metasfresh/metasfresh-webui-api-legacy#362) Add filters in Handling Units window
[#363](metasfresh/metasfresh-webui-api-legacy#363) make LU not mandatory in Receive HUs
[#364](metasfresh/metasfresh-webui-api-legacy#364) Replace HU editor's Barcode quick action with Barcode filter
[#370](metasfresh/metasfresh-webui-api-legacy#370) Avoid spamming the console with "Connection refused" when elasticsearch connection is not available

me-45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants