Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close all picking candidates only if the view was closed/removed by user #677

Closed
teosarca opened this issue Nov 15, 2017 · 2 comments
Closed

Close all picking candidates only if the view was closed/removed by user #677

teosarca opened this issue Nov 15, 2017 · 2 comments
Assignees
@metas-lc
Labels
branch:master branch:release type:bug

Comments

@teosarca
Copy link
Member

Is this a bug or feature request?

Bug

What is the current behavior?

The picking candidates are closed even if the view was removed because cache expired.

Which are the steps to reproduce?

none :(

What is the expected or desired behavior?

Close all picking candidates only if the view was closed/removed by user
@teosarca teosarca self-assigned this Nov 15, 2017
@teosarca
Copy link
Member Author

note to IT: the only thing u could test is regression, i.e. make sure the picking candidates are automatically closed when the packing terminal is closed.
That shall happen only for rack system picking slot!

teosarca added a commit that referenced this issue Nov 15, 2017
@teosarca
Close all picking candidates only if the view was closed/removed by user
99bf3f1 
#677
teosarca referenced this issue Nov 15, 2017
@teosarca
introduce ViewCloseReason
c222f79 
#664
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Nov 17, 2017
@metas-ts
Update ReleaseNotes.md
57a88ed 
[#2908](#2908) Provide
Doc Action voiding for contract period
[#2911](#2911) Create
Action for changing price and qty for a contract
[#2942](#2942) Fix the
message for PrintJob_Done
[#1335](metasfresh/metasfresh-webui-frontend-legacy#1335)
views: backend shall specify which columns are editable and how to
render the editor (frontend)
[#681](metasfresh/metasfresh-webui-api-legacy#681)
Picking not possible for >1 orderline in Picking Terminal
[#678](metasfresh/metasfresh-webui-api-legacy#678) HU
that was taken out in Picking Try Clearing shall remain Picked
[#670](metasfresh/metasfresh-webui-api-legacy#670)
views: backend shall specify which columns are editable and how to
render the editor
[#2963](#2963) flatrate:
use datepromised instead of order data for master and startdate
[#2975](#2975) sales
invoice jasper: group products by product category
[#2940](#2940) Shipment
Date = Promised Date
[#677](metasfresh/metasfresh-webui-api-legacy#677)
Close all picking candidates only if the view was closed/removed by user
[#2932](#2932) standalone
report / jasper service
[#1222](metasfresh/metasfresh-webui-frontend-legacy#1222)
Keyboard Shortcut for "Select all"/ "Select all x rows"
[#1964](#1964) ESR Import
w/o Invoice reference (w/ reversed Invoice)
[#2937](#2937) Jasper
Reports: New Purchase Order, Inout and Invoice Layout
[#2966](#2966) error in
console when creating customer return
[#2965](#2965) error for
HU changing locator if status E

me-45
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Nov 17, 2017
@metas-ts
Update ReleaseNotes.md
4cec9c6 
[#2908](#2908) Provide
Doc Action voiding for contract period
[#2911](#2911) Create
Action for changing price and qty for a contract
[#2942](#2942) Fix the
message for PrintJob_Done
[#1335](metasfresh/metasfresh-webui-frontend-legacy#1335)
views: backend shall specify which columns are editable and how to
render the editor (frontend)
[#681](metasfresh/metasfresh-webui-api-legacy#681)
Picking not possible for >1 orderline in Picking Terminal
[#678](metasfresh/metasfresh-webui-api-legacy#678) HU
that was taken out in Picking Try Clearing shall remain Picked
[#670](metasfresh/metasfresh-webui-api-legacy#670)
views: backend shall specify which columns are editable and how to
render the editor
[#2963](#2963) flatrate:
use datepromised instead of order data for master and startdate
[#2975](#2975) sales
invoice jasper: group products by product category
[#2940](#2940) Shipment
Date = Promised Date
[#677](metasfresh/metasfresh-webui-api-legacy#677)
Close all picking candidates only if the view was closed/removed by user
[#2932](#2932) standalone
report / jasper service
[#1222](metasfresh/metasfresh-webui-frontend-legacy#1222)
Keyboard Shortcut for "Select all"/ "Select all x rows"
[#1964](#1964) ESR Import
w/o Invoice reference (w/ reversed Invoice)
[#2937](#2937) Jasper
Reports: New Purchase Order, Inout and Invoice Layout
[#2966](#2966) error in
console when creating customer return
[#2965](#2965) error for
HU changing locator if status E

me-45

(cherry picked from commit 57a88ed)
@metas-lc metas-lc self-assigned this Dec 7, 2017
@metas-lc
Copy link

metas-lc commented Dec 7, 2017

IT

  1. go to picking slots window (picking tray) and make a slot rack system
  2. create and complete a sales order with at least 3 TUs. Go to picking slots and pick 2 HUs - one in a normal slot and one in the rack system slot
  3. press done
  4. press on pick again
    => the HUs are still on your slots OK
  5. select each HU and process picking
  6. press on pick again
    => only the HU that was not on rack system slot is shown OK
  7. press on done, create and complete the shipment using qty picked
  8. go to picking slots and use pick again
    => both slots are empty OK

@metas-lc metas-lc closed this as completed Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metas-lc metas-lc

Labels
branch:master branch:release type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teosarca @metas-ts @metas-lc