Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

views: backend shall specify which columns are editable and how to render the editor (frontend) #1335

Closed
teosarca opened this issue Nov 10, 2017 · 10 comments
Closed

views: backend shall specify which columns are editable and how to render the editor (frontend) #1335

teosarca opened this issue Nov 10, 2017 · 10 comments
Assignees
@metas-lc @wiadev
Labels
branch:master branch:release priority:high status:IT-failed type:enhancement

Comments

@teosarca
Copy link
Member

See metasfresh/metasfresh-webui-api-legacy#670

Related tasks:
@teosarca teosarca mentioned this issue Nov 10, 2017
Closed
@teosarca
Copy link
Member Author

Please also consider the issues reported here: #1274

@teosarca
Copy link
Member Author

teosarca commented Nov 13, 2017 •
edited
Loading

This is an important use case, required for metasfresh/metasfresh-webui-api-legacy#664

Use case for viewEditorRenderMode:"always"

  • have a sales order with at least one order line (u can use existing ones)
  • select the order lines and call the "Create purchase orders" action
  • check the layout of the fetched modal view, the QtyToPurchase and DatePromised shall render an field editor for each row.

In my example, i was using https://w101.metasfresh.com:8443/window/143/1000039
image
image

@wiadev wiadev mentioned this issue Nov 15, 2017
Merged
@metas-lc metas-lc self-assigned this Nov 16, 2017
@metas-lc
Copy link

tested in metasfresh/metasfresh-webui-api-legacy#670 OK

@teosarca teosarca reopened this Nov 16, 2017
@teosarca
Copy link
Member Author

Found following issues:

Editor patching endpoint is not correctly called.
Steps to reproduce:

image

image

@teosarca
Copy link
Member Author

Another issue: while editing the number:

  • if I press enter, the patch is not sent to server => NOK
  • if i press on component's arrow up/down to increment/decrement the number, the patch is not sent => NOK

wiadev added a commit that referenced this issue Nov 17, 2017
@wiadev
watch keydown event on 'always' tablecell #1335
37bfdc8
@wiadev wiadev mentioned this issue Nov 17, 2017
Merged
@wiadev
Copy link
Contributor

wiadev commented Nov 17, 2017

#1351

@wiadev
Copy link
Contributor

wiadev commented Nov 17, 2017

created new issue for handling wrong api call for view grid edit

@teosarca
Copy link
Member Author

10x, closing this one.

wiadev added a commit that referenced this issue Nov 17, 2017
@wiadev
hotfix for codeclimate #1335
35ec501
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Nov 17, 2017
@metas-ts
Update ReleaseNotes.md
57a88ed 
[#2908](#2908) Provide
Doc Action voiding for contract period
[#2911](#2911) Create
Action for changing price and qty for a contract
[#2942](#2942) Fix the
message for PrintJob_Done
[#1335](metasfresh/metasfresh-webui-frontend-legacy#1335)
views: backend shall specify which columns are editable and how to
render the editor (frontend)
[#681](metasfresh/metasfresh-webui-api-legacy#681)
Picking not possible for >1 orderline in Picking Terminal
[#678](metasfresh/metasfresh-webui-api-legacy#678) HU
that was taken out in Picking Try Clearing shall remain Picked
[#670](metasfresh/metasfresh-webui-api-legacy#670)
views: backend shall specify which columns are editable and how to
render the editor
[#2963](#2963) flatrate:
use datepromised instead of order data for master and startdate
[#2975](#2975) sales
invoice jasper: group products by product category
[#2940](#2940) Shipment
Date = Promised Date
[#677](metasfresh/metasfresh-webui-api-legacy#677)
Close all picking candidates only if the view was closed/removed by user
[#2932](#2932) standalone
report / jasper service
[#1222](metasfresh/metasfresh-webui-frontend-legacy#1222)
Keyboard Shortcut for "Select all"/ "Select all x rows"
[#1964](#1964) ESR Import
w/o Invoice reference (w/ reversed Invoice)
[#2937](#2937) Jasper
Reports: New Purchase Order, Inout and Invoice Layout
[#2966](#2966) error in
console when creating customer return
[#2965](#2965) error for
HU changing locator if status E

me-45
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Nov 17, 2017
@metas-ts
Update ReleaseNotes.md
4cec9c6 
[#2908](#2908) Provide
Doc Action voiding for contract period
[#2911](#2911) Create
Action for changing price and qty for a contract
[#2942](#2942) Fix the
message for PrintJob_Done
[#1335](metasfresh/metasfresh-webui-frontend-legacy#1335)
views: backend shall specify which columns are editable and how to
render the editor (frontend)
[#681](metasfresh/metasfresh-webui-api-legacy#681)
Picking not possible for >1 orderline in Picking Terminal
[#678](metasfresh/metasfresh-webui-api-legacy#678) HU
that was taken out in Picking Try Clearing shall remain Picked
[#670](metasfresh/metasfresh-webui-api-legacy#670)
views: backend shall specify which columns are editable and how to
render the editor
[#2963](#2963) flatrate:
use datepromised instead of order data for master and startdate
[#2975](#2975) sales
invoice jasper: group products by product category
[#2940](#2940) Shipment
Date = Promised Date
[#677](metasfresh/metasfresh-webui-api-legacy#677)
Close all picking candidates only if the view was closed/removed by user
[#2932](#2932) standalone
report / jasper service
[#1222](metasfresh/metasfresh-webui-frontend-legacy#1222)
Keyboard Shortcut for "Select all"/ "Select all x rows"
[#1964](#1964) ESR Import
w/o Invoice reference (w/ reversed Invoice)
[#2937](#2937) Jasper
Reports: New Purchase Order, Inout and Invoice Layout
[#2966](#2966) error in
console when creating customer return
[#2965](#2965) error for
HU changing locator if status E

me-45

(cherry picked from commit 57a88ed)
teosarca added a commit that referenced this issue Nov 20, 2017
@teosarca
Merge pull request #1350 from metasfresh/dev-1335
896ad0d 
watch keydown event on 'always' tablecell #1335
@teosarca teosarca reopened this Nov 20, 2017
@teosarca
Copy link
Member Author

note to IT: pls test:

if I press enter, the patch is not sent to server => NOK"

@teosarca teosarca mentioned this issue Nov 20, 2017
Closed
This was referenced Nov 20, 2017
Closed
Closed
Closed
@teosarca
Copy link
Member Author

closing it because everything which did not work was moved to individual tasks.

even

if I press enter, the patch is not sent to server => NOK"

which is kind of not working, shall be fixed on #1358

@wiadev wiadev mentioned this issue Nov 21, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@metas-lc metas-lc

@wiadev wiadev

Labels
branch:master branch:release priority:high status:IT-failed type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@teosarca @metas-ts @metas-lc @wiadev