Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide to frontend: tab allow create new and delete as they change #252

Closed
teosarca opened this issue Mar 14, 2017 · 3 comments
Closed

Comments

@teosarca
Copy link
Member

What is the current behavior?

If an included tab allows creating new documents or deleting existing documents is not provided to frontend.
So the frontend is always showing the buttons for creating/deleting included documents.
If the option is not allowed it will fail when user presses the button.

What is the expected or desired behavior?

That information shall be provided to frontend ASAP.
The frontend shall not display those options if not available => we will create a frontend task, as a follow-up of this task.

teosarca added a commit to metasfresh/metasfresh that referenced this issue Mar 15, 2017
@teosarca teosarca self-assigned this Mar 15, 2017
metas-ts added a commit that referenced this issue Mar 17, 2017
#252 Provide to frontend: tab allow create new and delete as they change
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Mar 17, 2017
[#1152](#1152) Support address sequence configuration in multi org environment
[#252](metasfresh/metasfresh-webui-api-legacy#252) Provide to frontend: tab allow create new and delete as they change
[#1165](#1165) QtyDelivered not set back correctly after reactivating and voiding a material receipt
@metas-lc metas-lc self-assigned this Mar 18, 2017
@metas-lc
Copy link

metas-lc commented Mar 18, 2017

IT:
sales/purchase order
on new:
0. allowCreateNew:false
allowDelete:true.....................................................................OK? (checked: OK)

  1. allowCreateNew:false
    allowDelete:false

on existing, uncompleted document:
0. allowCreateNew:true
allowDelete:true

  1. allowCreateNew:false
    allowDelete:false

on completed document
0. allowCreateNew:false
allowDelete:false

  1. allowCreateNew:false
    allowDelete:false

Tested also in business partner - i could add and remove e.g. location
creating and completing orders went fine. Line for Tu was added. Tried to add a product after it was completed - got error . OK
TODO: see e2e (rest is OK) (checked e2e was fine too)

@metas-lc
Copy link

IT2

  1. new order, set all mandatory fields
  2. add an empty line (using add new with no product)
    => allowCreateNew:false, allowDelete:false OK
  3. add mandatory field on line (the product)
    => allowCreateNew:true, allowDelete:true OK
  4. remove mandatory field bpartner from order
    => allowCreateNew:true, allowDelete:true NOK
    created follow-up: update allow create new and delete #271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants