Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Don't use deprecated staleTabIds #540

Closed
teosarca opened this issue Mar 15, 2017 · 4 comments
Closed

Don't use deprecated staleTabIds #540

teosarca opened this issue Mar 15, 2017 · 4 comments
Assignees
@damianprzygodzki @metas-lc
Labels
branch:master branch:release type:enhancement
Milestone
2017-15

Comments

@teosarca
Copy link
Member

Current behavior

All document changes responses were an array called staleTabIds.
That are was used to flag stale tabs on frontend side.
In meantime we refactored and restructured a bit the response....

Expected behavior

We introduced "includedTabsInfo" which contains an array on "tab changes".
Each change might contain a property called "stale". If that property is set and it's true the tab shall considered stale.

See the screenshot below to picture the change....

image
@teosarca teosarca added this to the 2017-12 milestone Mar 15, 2017
@teosarca
Copy link
Member Author

Blocked by metasfresh/metasfresh-webui-api-legacy#252

@cadavre cadavre modified the milestones: 2017-13, 2017-12 Mar 21, 2017
@damianprzygodzki damianprzygodzki self-assigned this Mar 22, 2017
@teosarca
Copy link
Member Author

note: metasfresh/metasfresh-webui-api-legacy#252 was integrated.

damianprzygodzki added a commit that referenced this issue Mar 23, 2017
@damianprzygodzki
#540 Refreshing tabs relies on includedTabsInfo
ad84be9
damianprzygodzki added a commit that referenced this issue Mar 23, 2017
@damianprzygodzki
Merge pull request #573 from metasfresh/dev-540
d10135d 
#540 Refreshing tabs relies on includedTabsInfo
@metas-lc
Copy link

for IT: test after metasfresh/metasfresh-webui-api-legacy#273 is done

@metas-mk metas-mk modified the milestones: 2017-15, 2017-13 Apr 5, 2017
@metas-lc metas-lc self-assigned this Apr 6, 2017
@metas-dh
Copy link
Member

metasfresh/metasfresh-webui-api-legacy#273 was tested successfully, closing this also.

metasfresh/metasfresh-webui-api-legacy#252 & #541 were also tested successfully.

@damianprzygodzki damianprzygodzki mentioned this issue May 22, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@damianprzygodzki damianprzygodzki

@metas-lc metas-lc

Labels
branch:master branch:release type:enhancement
Projects
None yet
Milestone
2017-15
Development

No branches or pull requests
7 participants
@cadavre @teosarca @metas-ts @damianprzygodzki @metas-mk @metas-lc @metas-dh