Merge pull request #1133 from metasfresh/dev-1130

#1130 Fix improper handling of initialFocus in conjunction with clear value
metasfresh · Aug 15, 2017 · 08862a1 · 08862a1
2 parents edb3e19 + 4d6bca6
commit 08862a1
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/src/components/widget/Lookup/RawLookup.js b/src/components/widget/Lookup/RawLookup.js
@@ -29,7 +29,7 @@ class RawLookup extends Component {
     }
 
     componentDidMount() {
-        const { selected, defaultValue } = this.props;
+        const { selected, defaultValue, initialFocus } = this.props;
 
         this.handleValueChanged();
 
@@ -44,15 +44,18 @@ class RawLookup extends Component {
             let defaultKey = Object.keys(defaultValue)[0];
             this.inputSearch.value = defaultValue[defaultKey];
         }
+
+        if (initialFocus && !this.inputSearch.value) {
+            this.inputSearch.focus();
+        }
     }
 
     componentDidUpdate(prevProps) {
         this.handleValueChanged();
 
         const {
             autoFocus, defaultValue, fireClickOutside, handleInputEmptyStatus,
-            filterWidget, initialFocus, lookupEmpty, localClearing,
-            resetLocalClearing, fireDropdownList
+            filterWidget, lookupEmpty, localClearing, resetLocalClearing, fireDropdownList
         } = this.props;
 
         const { shouldBeFocused } = this.state;
@@ -69,10 +72,6 @@ class RawLookup extends Component {
             });
         }
 
-        if (initialFocus && !this.inputSearch.value) {
-            this.inputSearch.focus();
-        }
-
         defaultValue && prevProps.defaultValue !== defaultValue &&
         handleInputEmptyStatus(false);