Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Offline message is no longer displayed #1156

Closed
teosarca opened this issue Aug 23, 2017 · 5 comments
Closed

Offline message is no longer displayed #1156

teosarca opened this issue Aug 23, 2017 · 5 comments

Comments

@teosarca
Copy link
Member

Type of issue

Bug

Current behavior

If the server is down, the frontend screen is grayed out (OK) but there is no message displayed.

Expected behavior

The offline mode message shall be displayed.

See also / might be related to:

@wiadev wiadev assigned wiadev and unassigned wiadev Aug 28, 2017
@wiadev
Copy link
Contributor

wiadev commented Sep 8, 2017

@teosarca This works fine UNTIL we reload the page (while staying offline).

If we try to refresh page without connection established (e.g. being offline) - localized messages doesn't load as well, thus nothing to display.

If your server is down, it's very unlikely to get anything in response to API i18n/messages request.

Then we're getting empty list of localized messages, thus when component displays error message (expecting localized strings) it couldn't display anything.

I will add english fallback message if locale isn't loaded.

@teosarca
Copy link
Member Author

teosarca commented Sep 8, 2017

@wiadev

I will add english fallback message if locale isn't loaded.

yes.

I guess, complementary, i shall instruct the browser to cache the i18n/messages response (using Cache-control header). wdyt?

@wiadev
Copy link
Contributor

wiadev commented Sep 8, 2017

@teosarca
This is optional, but might help for some cases. There are no any guarantees from browser that such requests will be surely cached. It could put into cache or not. Imagine the case when user turned it off (cache). Or no free disk space. Yes, these cases are not that often, but it could happen so browser will not use cache anymore.

wiadev added a commit that referenced this issue Sep 8, 2017
Offline message now correctly display in case when user refreshes the page again without connection established
@teosarca
Copy link
Member Author

teosarca commented Sep 8, 2017

Thanks for input @wiadev .
But still, we can have this caching (I will implement sometime in the future) and ALSO have the fallback message on frontend side (which will be implemented by you in this task).

teosarca added a commit that referenced this issue Sep 8, 2017
Offline message without connection established #1156
metas-mk added a commit to metasfresh/metasfresh that referenced this issue Sep 8, 2017
Adding a new Issue to Release Notes
metasfresh/metasfresh-webui-frontend-legacy#1156
Offline message is no longer displayed
@metas-dh
Copy link
Member

Results of IT1
tested in mf15

  • correct msg displayed when Server is down (e.g. during rollout), not just grayed out screen: OK

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants