d3 errors on dashboard

[metas-lc]

Is this a bug or feature request?

bug

What is the current behavior?

you get flooded with errors in console when you open the dashboard

Which are the steps to reproduce?

open https://w101.metasfresh.com:8443/ see console

What is the expected or desired behavior?

no errors

[wiadev]

@teosarca @metas-lc
can't reproduce the error anymore.

Also, I found another issue while I'm playing around.

[wiadev]

@teosarca the reason for this is we are getting negative values (less than 0) from the backend.

How does it work? are we supposed to have negative values, as well?

[teosarca]

@wiadev 10x. I think this shall be handled on backend side and in case of pie charts always send positive numbers.

[wiadev]

@teosarca cool
FYI, it's not pie charts but bar charts are causing the issues.

[teosarca]

@wiadev hmm, but on bar charts we shall be able to display negative numbers, isn't it?

[wiadev]

@teosarca we can draw negative values below the x-axis but at the moment, negative values are setting for heights.
height should be positive and y(position) should be changed.

do you want me to check?
and my question was if we were supposed to get negative values for bar charts.(e.g products)

[teosarca]

do you want me to check?

yes pls

and my question was if we were supposed to get negative values for bar charts.(e.g products)

depends on each bar chart, but i don't see why not.

[metas-ts]

i can also see a number of interesting cases for negative bar charts (scnr)

[wiadev]

@teosarca

you can hardly see it because the offset(negative number) -6.9 vs 64000(max).

FYI, I've added additional x-axis at y:0 if there is a negative value to make it more visible.

[teosarca]

did a quick test: open the dashboard and look at that barchat with negative numbers.
Each time it's refreshed (atm it's configured each second) the barchart is animated, even there was NO change => NOK

[wiadev]

@teosarca is it refreshed every second? on my end, it's refreshed very occasionally.
Also, we set the animation in d3 library and we are not keeping the previous data. so we don't know if data was changed or not.

[teosarca]

@wiadev but it's weird that only for this one is happening. All the others, AFAIK, are moving nicely when data is changed.

[metas-mk]

Quick test before merge

[teosarca]

@metas-mk we need a barchart with negative values in order to test the feature.

note to IT: try to create some negative sales orders or something just to have an negative revenue for some of those products.

[metas-lc]

IT
created/completed a sales order with qty -100
checked dashboard: looks like this (NOK)

rest is ok: no refreshing and no errors (OK)

[wiadev]

@metas-lc confirmed on w101. leave the negative values as it is while I'm working, please.

[metas-lc]

@wiadev btw i think on w101 the task is not rolled out. I was testing somewhere else. I won't change the values on w101. Let me know if you need rollout

[wiadev]

@metas-lc even though you didn't roll out, you updated the w101 DB to have negative values to test, right?

[metas-lc]

@wiadev yes, i wanted to confirm it's a bug. But then i noticed it doesn't look like it was rolled out. You can remove the order i did: https://w101.metasfresh.com:8443/window/143/1000297
from now on, i won't change numbers :)

[wiadev]

@metas-lc no I need those numbers so I can reproduce on my end, as well. :) all good. leave them, please.

[wiadev]

@metas-lc can you roll out this on w101 and test again?

[metas-lc]

IT
checked again, looks fine and there are no errors