Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Support Lookup view attributes #1433

Closed
teosarca opened this issue Dec 10, 2017 · 5 comments
Closed

Support Lookup view attributes #1433

teosarca opened this issue Dec 10, 2017 · 5 comments

Comments

@teosarca
Copy link
Member

teosarca commented Dec 10, 2017

required for metasfresh/metasfresh-webui-api-legacy#727

What is the current behavior?

The Lookup view attributes are not supported.

Which are the steps to reproduce?

  • open material receipt candidates: https://w101.metasfresh.com:8443/window/540196
  • select a line and try to receive => the HU editor modal is opened
  • select first HU line, and take a look at the view attributes from right side
  • Unterlieferanten and Karoten ID are lookups but i cannot use them, feels like the fields are kind-of readonly.
    image

What is the expected or desired behavior?

The view attributes with widgetType:lookup shall work.
The typeahead endpoint to be used is http://w101.metasfresh.com:8081/swagger-ui.html#!/view-row-attributes-rest-controller/getAttributeTypeaheadUsingGET_2

wiadev added a commit that referenced this issue Dec 12, 2017
- add getviewAttributeTypeahead() with new api
- integrate new typeahead api in lookup widget
teosarca added a commit that referenced this issue Dec 13, 2017
teosarca added a commit that referenced this issue Dec 14, 2017
Fix support various typeahead requests #1433
@teosarca
Copy link
Member Author

note to IT:

  • regression: make sure lookups are working in document header, included documents, view attributes (e.g. sub producer) and process param.

@metas-lc
Copy link

IT
can't see any data here and i understood it's related with this task
see: https://w101.metasfresh.com:8443/window/184/1000111

error

react-dom.production.min.js:164 TypeError: Cannot read property 'widgetType' of undefined
    at _react2.default.createElement.properties.map (Lookup.js:243)
    at Array.map (<anonymous>)
    at Lookup.render (Lookup.js:234)
    at h (react-dom.production.min.js:130)
    at beginWork (react-dom.production.min.js:133)
    at d (react-dom.production.min.js:161)
    at f (react-dom.production.min.js:161)
    at g (react-dom.production.min.js:162)
    at m (react-dom.production.min.js:169)
    at w (react-dom.production.min.js:168)
h @ react-dom.production.min.js:164
g @ react-dom.production.min.js:162
m @ react-dom.production.min.js:169
w @ react-dom.production.min.js:168
z @ react-dom.production.min.js:167
u @ react-dom.production.min.js:165
enqueueSetState @ react-dom.production.min.js:108
A.setState @ react.production.min.js:12
onStateChange @ connectAdvanced.js:222
notify @ Subscription.js:30
notifyNestedSubs @ Subscription.js:69
onStateChange @ connectAdvanced.js:219
dispatch @ createStore.js:186
(anonymous) @ middleware.js:22
(anonymous) @ index.js:14
dispatch @ applyMiddleware.js:45
then.response @ WindowActions.js:385
Promise resolved (async)
dispatch.then.response @ WindowActions.js:385
Promise resolved (async)
dispatch @ WindowActions.js:333
(anonymous) @ index.js:11
onEnter @ routes.js:78
transitionHook @ TransitionUtils.js:48
(anonymous) @ TransitionUtils.js:119
(anonymous) @ TransitionUtils.js:89
next @ AsyncUtils.js:39
loopAsync @ AsyncUtils.js:56
runTransitionHooks @ TransitionUtils.js:88
runEnterHooks @ TransitionUtils.js:112
(anonymous) @ createTransitionManager.js:95
runTransitionHooks @ TransitionUtils.js:79
runChangeHooks @ TransitionUtils.js:136
finishMatch @ createTransitionManager.js:92
(anonymous) @ createTransitionManager.js:70
next @ AsyncUtils.js:46
loopAsync @ AsyncUtils.js:56
matchRoutes @ matchRoutes.js:245
match @ createTransitionManager.js:66
historyListener @ createTransitionManager.js:247
listen @ createTransitionManager.js:271
componentWillMount @ Router.js:122
mountClassInstance @ react-dom.production.min.js:110
beginWork @ react-dom.production.min.js:133
d @ react-dom.production.min.js:161
f @ react-dom.production.min.js:161
g @ react-dom.production.min.js:162
m @ react-dom.production.min.js:169
w @ react-dom.production.min.js:168
z @ react-dom.production.min.js:167
u @ react-dom.production.min.js:165
updateContainer @ react-dom.production.min.js:175
(anonymous) @ react-dom.production.min.js:225
unbatchedUpdates @ react-dom.production.min.js:171
Pg @ react-dom.production.min.js:225
render @ react-dom.production.min.js:227
(anonymous) @ index.jsx:6
__webpack_require__ @ bootstrap 90da27057a370f2306a5:19
(anonymous) @ bootstrap 90da27057a370f2306a5:39
__webpack_require__ @ bootstrap 90da27057a370f2306a5:19
(anonymous) @ bootstrap 90da27057a370f2306a5:39
(anonymous) @ bootstrap 90da27057a370f2306a5:39
Lookup.js:243 Uncaught (in promise) TypeError: Cannot read property 'widgetType' of undefined
    at _react2.default.createElement.properties.map (Lookup.js:243)
    at Array.map (<anonymous>)
    at Lookup.render (Lookup.js:234)
    at h (react-dom.production.min.js:130)
    at beginWork (react-dom.production.min.js:133)
    at d (react-dom.production.min.js:161)
    at f (react-dom.production.min.js:161)
    at g (react-dom.production.min.js:162)
    at m (react-dom.production.min.js:169)
    at w (react-dom.production.min.js:168)

@teosarca
Copy link
Member Author

pls do not cherry pick this week !

@teosarca
Copy link
Member Author

note to IT: pls test it together with #1451.

@metas-lc
Copy link

IT

  1. setting Unterlieferanten attribute in hu editor
    => field is editable, and you can select your bpartner by name (might need to to a followup because it doesn't work with value and/or gap) OK

  2. create and open a material receipt
    => window opens without errors OK

  3. regression: checking lookups
    worked fine OK

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Dec 18, 2017
[#706](metasfresh/metasfresh-webui-api-legacy#706)
Port current MRP Product Info Window to the webui
[#755](metasfresh/metasfresh-webui-api-legacy#755)
Processes: support for parentViewSelectedIds and childViewSelectedIds
[#1427](metasfresh/metasfresh-webui-frontend-legacy#1427)
d3 errors on dashboard
[#2646](#2646) MRP
Product Info Just in Time
[#751](metasfresh/metasfresh-webui-api-legacy#751)
Picking Tray Clearing: packing HUs: Add to Transportation Order action
[#1437](metasfresh/metasfresh-webui-frontend-legacy#1437)
Language bug: The language in Settings is not respected
[#746](metasfresh/metasfresh-webui-api-legacy#746)
Picking Tray Clearing: Scan picking slot barcode filter
[#1455](metasfresh/metasfresh-webui-frontend-legacy#1455)
error when updating an attribute multiple times
[#747](metasfresh/metasfresh-webui-api-legacy#747)
Picking Tray Clearing: filter picking slots by Partner
[#1433](metasfresh/metasfresh-webui-frontend-legacy#1433)
Support Lookup view attributes
[#3211](#3211) Picking
Tray Clearing: right side view shall display only the HUs for current
BP/Location
[#1444](metasfresh/metasfresh-webui-frontend-legacy#1444)
Attributes are empty in material receipt candidate
[#3202](#3202) Error in
Paymentjournal Process/ Report in Payselection
[#3193](#3193) Improve
Window for manual OnHand Qty in WebUI
[#1448](metasfresh/metasfresh-webui-frontend-legacy#1448)
jenkins: fix current lint issues
[#1435](metasfresh/metasfresh-webui-frontend-legacy#1435)
Problem regarding multiple filters
[#1436](metasfresh/metasfresh-webui-frontend-legacy#1436)
Remove legacy docs
[#3169](#3169) Updating
PMM_Week availability trend fails
[#1206](metasfresh/metasfresh-webui-frontend-legacy#1206)
Use automatic code style enforcement
[#717](metasfresh/metasfresh-webui-api-legacy#717)
picking terminal: open HUs to pick shall display Best Before date and
Locator

me-45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants