Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

frontend: Document included tab: pluggable actions to start a process #2157

Closed
teosarca opened this issue Jan 23, 2019 · 7 comments
Closed

frontend: Document included tab: pluggable actions to start a process #2157

teosarca opened this issue Jan 23, 2019 · 7 comments
Assignees
@siemiatj
Labels
branch:master branch:release priority:high type:enhancement

Comments

@teosarca
Copy link
Member

teosarca commented Jan 23, 2019 •
edited
Loading

Is this a bug or feature request?

FR
backend task: metasfresh/metasfresh-webui-api-legacy#1134

What is the current behavior?

Which are the steps to reproduce?

What is the expected or desired behavior?

image
@teosarca teosarca mentioned this issue Jan 25, 2019
Closed
teosarca added a commit to metasfresh/metasfresh that referenced this issue Jan 26, 2019
@teosarca
Env: more getter/setters
a9256ee 
metasfresh/metasfresh-webui-frontend-legacy#2157
teosarca added a commit to metasfresh/metasfresh that referenced this issue Jan 26, 2019
@teosarca
Document included tab: pluggable actions to start a process
4af7aaa 
metasfresh/metasfresh-webui-frontend-legacy#2157
@teosarca
Copy link
Member Author

Backend is ready.

Basically, each time an included tab is activated, please fetch tab's top actions using http://w101.metasfresh.com:8080/swagger-ui.html#/window-rest-controller/getIncludedTabTopActionsUsingGET endpoint.

Render those actions.

When user clicks on one of them, the action shall be called like any other action that we have.

@siemiatj siemiatj self-assigned this Feb 1, 2019
@siemiatj
Copy link
Contributor

siemiatj commented Feb 6, 2019 •
edited
Loading

Related to #1009

siemiatj added a commit that referenced this issue Feb 6, 2019
@siemiatj
- api for topActions #2157
fcd986d
siemiatj added a commit that referenced this issue Feb 6, 2019
@siemiatj
- render topActions in Table #2157
118562f
siemiatj added a commit that referenced this issue Feb 6, 2019
@siemiatj
- do the process request when button is clicked #2157
a012ead
@siemiatj siemiatj mentioned this issue Feb 6, 2019
Merged
siemiatj added a commit that referenced this issue Feb 6, 2019
@siemiatj
- changes in props and params order #2157
b3c6a7b
siemiatj added a commit that referenced this issue Feb 7, 2019
@siemiatj
- fix parameters sent to createProcess #2157
9d43b5d
siemiatj added a commit that referenced this issue Feb 7, 2019
@siemiatj
- add missing props #2157
df7c613
siemiatj added a commit that referenced this issue Feb 12, 2019
@siemiatj
- fix rendering table filter buttons #2157
a741eb9
@teosarca
Copy link
Member Author

quick tested, works
i.e. Open/Create a new sales order. In the order line tabs you shall have the Products proposal button.
Press on it, the products proposal modal shall be opened.
image

image

@teosarca teosarca changed the title Document included tab: pluggable actions to start a process frontend: Document included tab: pluggable actions to start a process Feb 13, 2019
@teosarca
Copy link
Member Author

found following issue:

  • open sales order
  • on lines tab, click on Products Proposal button => works!
  • select one of the order lines
  • click again on Products Proposal button => does nothing => NOK

siemiatj added a commit that referenced this issue Feb 13, 2019
@siemiatj
- fix selecting tab from array #2157
f2aa079
@siemiatj
Copy link
Contributor

Looks like I've introduced an error trying to fix something else. Should the row selection influence the products proposal modal in any way ? Cause no matter which row I select I'm always getting the same results. Data sent with the request looks fine though.

screen shot 2019-02-13 at 17 45 38

@siemiatj siemiatj mentioned this issue Feb 13, 2019
Merged
@teosarca
Copy link
Member Author

Should the row selection influence the products proposal modal in any way ?

Nop, in that case not. "More products..." shall be shown no matter what rows are selected.

@metas-dh
Copy link
Member

Results of IT1
tested in mf15

Sales order:

  • Products proposal button:
    • not in actions anymoreress on it, but order line tabs: OK
    • the products proposal modal is opened when clicking the button: OK
  • the products proposal modal is opened:
    • when 1 orderline is selected: OK
    • when >1 orderline is selected: OK
    • when no orderline is selected: OK (i guess)
    • every time when the button is clicked: OK
  • actions in the Products proposal modal: More products (no matter which line in the modal is selected): OK

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Feb 18, 2019
@metas-ts
Update ReleaseNotes.md
0a967d8 
  * [#4916](#4916) Checkbox Newsletter in der Neuaufnahme anzeigen
  * [#4952](#4952) Implement Campain Pricing Rule
  * [#4953](#4953) Add taxId to function docs_generics_org_report
  * [#1142](metasfresh/metasfresh-webui-api-legacy#1142) Make Issue CUs from Source HU work for Multi Select
  * [#1148](metasfresh/metasfresh-webui-api-legacy#1148) Products proposal: display the prices paid by other customers
  * [#2147](metasfresh/metasfresh-webui-frontend-legacy#2147) Display process descriptions that are provided by the API
  * [#2157](metasfresh/metasfresh-webui-frontend-legacy#2157) frontend: Document included tab: pluggable actions to start a process
  * [#2145](metasfresh/metasfresh-webui-frontend-legacy#2145) Model view: row no longer refreshed
  * [#2160](metasfresh/metasfresh-webui-frontend-legacy#2160) Selected row not always correctly recognized
  * [#2162](metasfresh/metasfresh-webui-frontend-legacy#2162) View quick actions shall not display scrollbar
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@siemiatj siemiatj

Labels
branch:master branch:release priority:high type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@siemiatj @teosarca @metas-ts @metas-dh