Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Implement ProcessButton widget #250

Closed
metas-mk opened this issue Feb 6, 2017 · 10 comments
Closed

Implement ProcessButton widget #250

metas-mk opened this issue Feb 6, 2017 · 10 comments
Assignees
Milestone

Comments

@metas-mk
Copy link
Member

metas-mk commented Feb 6, 2017

Button Widget in Subtab Lines and/ or Advanced Edit

  • Is a process Button that has to Open a Process Parms Widget and start underlying Process.

image

@cadavre
Copy link
Contributor

cadavre commented Feb 8, 2017

@teosarca how shall we handle this from API?

This widget is rendered by:

{
displayed:true
field:"ProcCreate"
mandatory:false
readonly:false
valid:true
value:"N"
widgetType:"Button"
}

Shall you attach processId into widget?

@damianprzygodzki
Copy link
Contributor

damianprzygodzki commented Feb 8, 2017

Whatsmore we don't have sth like "Process Parms Widget". All processes are handled by modals.

EDIT: I am now thinking if we should provide a new Widget Type to begin process (not starting, but getting layout, data and so on...) like "ProcessButton", that would get a processId in value property to DO NOT CHANGE current widget data structure.

I am more into adding property "caption" for buttons, than "processId".

@teosarca
Copy link
Member

teosarca commented Feb 8, 2017

need to think....

@damianprzygodzki
Copy link
Contributor

In referenced issue, what we have to remember, that buttons should handle redirecting too.

@cadavre cadavre modified the milestones: 2017-07, 2017-08 Feb 14, 2017
@teosarca teosarca removed their assignment Feb 16, 2017
@teosarca teosarca changed the title Button Widget in Subtab Lines and/ or Advanced Edit Implement ProcessButton widget Feb 20, 2017
@teosarca
Copy link
Member

I've introduced a new widget type, called ProcessButon.
It shall be rendered as Button widget but:

  • it shall display the element caption, always (instead of "value")
  • when button is clicked it shall start the given process instead.
  • readonly means button is not pressable (disabled)
  • mandatory shall be ignored
  • displayed shall be considered, so if displayed=false, the button shall not be displayed

Running the process

A new property was introduced in element, called "buttonProcessId".
When the button is clicked the process identified with that ID shall be started.
See http://w101.metasfresh.com:8081/swagger-ui.html#!/process-rest-controller/createInstanceFromRequestUsingPOST .

In the create request, along with documentType and documentId two new properties shall be provided if the button is on an included document: the "tabId" and "rowId".

image

@teosarca teosarca modified the milestones: 2017-09, 2017-08 Feb 21, 2017
@teosarca
Copy link
Member

teosarca commented Feb 21, 2017

API is ready: metasfresh/metasfresh-webui-api-legacy#161

@metas-rc
Copy link
Member

Results of IT1: OK

Tested on http://w101.metasfresh.com:8090

The button works correctly, no error in the console.

The backend test was also performed, the process is working correctly. See Daniela's results on https://github.com/metasfresh/metasfresh-documentation/blob/master/_tests_collection/Testcase_%23161.md

@teosarca
Copy link
Member

IMHO it's not OK.

Test case:

@damianprzygodzki
Copy link
Contributor

damianprzygodzki commented Feb 24, 2017

There is no option to have two modals opened at the same time. Processes needs opened modal too. This issue returning on and on.

@teosarca
Copy link
Member

teosarca commented Feb 24, 2017

As we talked, this issue shall be solved in #429

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants