Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Don't render unknown widget types but log in console #376

Closed
teosarca opened this issue Feb 20, 2017 · 2 comments
Closed

Don't render unknown widget types but log in console #376

teosarca opened this issue Feb 20, 2017 · 2 comments
Assignees
@damianprzygodzki @metas-rc
Labels
branch:master branch:release type:enhancement
Milestone
2017-09

Comments

@teosarca
Copy link
Member

reasons:

  • it will allow us to introduce widget types ahead
  • it's there is no use to have them there
  • a WARN in console would be enough

For example: Price list, advance edit one of the rows, see the ProcessButton which is an unknown widget type (which will be implemented in one of the next issues).

image
@teosarca teosarca added this to the 2017-09 milestone Feb 20, 2017
@teosarca
Copy link
Member Author

only if it's a quick fix

@damianprzygodzki damianprzygodzki self-assigned this Feb 21, 2017
damianprzygodzki added a commit that referenced this issue Feb 21, 2017
@damianprzygodzki
#376 Fallback for unsupported widget type
2817986
damianprzygodzki added a commit that referenced this issue Feb 21, 2017
@damianprzygodzki
Merge pull request #385 from metasfresh/dev-376
0611484 
#376 Fallback for unsupported widget type
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Feb 21, 2017
@metas-ts
Update ReleaseNotes.md
52bf84c 
[#376](metasfresh/metasfresh-webui-frontend-legacy#376) Don't render unknown widget types but log in console
[#150](metasfresh/metasfresh-webui-api-legacy#150) Material Receipt Candidates not updated after receive HU
@metas-rc metas-rc self-assigned this Feb 22, 2017
@metas-rc
Copy link
Member

metas-rc commented Feb 23, 2017 •
edited
Loading

Results of IT1

Tested on http://w101.metasfresh.com:8090

I tested this before #250 was integrated but I wasn't able to get to the advanced editing back then because of another bug.
Any ways, I saw the log in console about the unimplemented widget type so I think this was solved.

OK

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@damianprzygodzki damianprzygodzki

@metas-rc metas-rc

Labels
branch:master branch:release type:enhancement
Projects
None yet
Milestone
2017-09
Development

No branches or pull requests
4 participants
@teosarca @metas-ts @damianprzygodzki @metas-rc