Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Grid view selection lost when trying to use the scroll bar #259

Closed
teosarca opened this issue Feb 8, 2017 · 14 comments
Closed

Grid view selection lost when trying to use the scroll bar #259

teosarca opened this issue Feb 8, 2017 · 14 comments

Comments

@teosarca
Copy link
Member

teosarca commented Feb 8, 2017

image

@teosarca
Copy link
Member Author

teosarca commented Feb 8, 2017

More, the selection is changed even if i am clicking somewhere in the page.... that shall be fixed too

@damianprzygodzki
Copy link
Contributor

Scroll bar looks like a bug, or changes in the browser behavior. But selection is always disappearing when we click outside the table.

@cadavre
Copy link
Contributor

cadavre commented Feb 8, 2017

"click outside the table" is always expected action. It is pattern also used everywhere else in metasfresh. It only shouldn't de-select on moving into Selection attributes or when pressing one of Quick actions (which is obvious).

But scrollbar shouldn't deselect – that's true.

@bambeusz
Copy link
Contributor

bambeusz commented Feb 13, 2017

It seems that in modern browsers scrollbar is not visible by default, it's shown only when the user scrolls (at least on OSX). For the browser clicking a few pixels from right edge, is equal to clicking on scrollbar. This makes detecting of click on scrollbar impossible, as it is just an area, very close to right side.

Another thing is that scrollbar of the whole content is not always the only scrollbar on the page. We'd need to detect clicking on scrollbar on every container.

imho, metasfresh is keyboard navigation friendly, isn't it? What's the point of scrolling down with mouse click, while there is far better way to do it. E.g. using arrows, or scrolling with mouse scroll.

wdyt

@teosarca
Copy link
Member Author

Suggestion: as discussed last week, deselect the row only when clicking in the parent container.
I am open on any other suggestion which would have a similar effect (i.e. don't deselect on scrollbar).

@chmieludaniel

imho, metasfresh is keyboard navigation friendly, isn't it? What's the point of scrolling down with mouse click, while there is far better way to do it. E.g. using arrows, or scrolling with mouse scroll.

IMHO that would be a big usability drawback.
Scrollbars are also a conventional indicator that there is more to see...

Dunkat added a commit that referenced this issue Feb 20, 2017
damianprzygodzki added a commit that referenced this issue Feb 20, 2017
Fix grid view selection lost #259
@metas-lc metas-lc self-assigned this Feb 20, 2017
@metas-ts
Copy link
Member

metas-ts commented Feb 20, 2017

@teosarca @metas-lc if you move a task to test or if you pick up a task for testing please check and make sure that the task is in the release notes.
i'm adding this one now

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Feb 20, 2017
[#259](metasfresh/metasfresh-webui-frontend-legacy#259) Grid view selection lost when trying to use the scroll bar
@metas-lc
Copy link

Where do i have to select so my line would get unselected?
modal

@damianprzygodzki
Copy link
Contributor

@Dunkat ?

@metas-lc
Copy link

was the fix integrated? I didn't notice any difference

@metas-lc
Copy link

if there was a way to unselect the lines, i would expect to click somewhere in the white space. Maybe i am wrong

@metas-lc metas-lc reopened this Feb 24, 2017
@metas-rc metas-rc reopened this Feb 24, 2017
@metas-mk metas-mk modified the milestones: 2017-09, 2017-08 Feb 28, 2017
@Dunkat
Copy link
Contributor

Dunkat commented Feb 28, 2017

something broke, maybe in another merge, need to check

damianprzygodzki added a commit that referenced this issue Feb 28, 2017
damianprzygodzki added a commit that referenced this issue Feb 28, 2017
@Dunkat
Copy link
Contributor

Dunkat commented Feb 28, 2017

Should work now. Just click outside table in the white space.

@metas-lc
Copy link

metas-lc commented Mar 3, 2017

IT

  • select the line and then select white space => line is deselected OK
  • select the line and then change attributes => line is still selected OK
  • select the line and then select the vertical scrollbar => line is deselected NOK
  • select the line and then select the horizontal scrollbar => line is deselected NOK

@metas-mk metas-mk modified the milestones: 2017-10, 2017-09 Mar 6, 2017
Dunkat added a commit that referenced this issue Mar 6, 2017
damianprzygodzki added a commit that referenced this issue Mar 6, 2017
Fix deselect row on scroll click in modal #259
@metas-mk
Copy link
Member

metas-mk commented Mar 6, 2017

Tested. Works nicely as required.
Retested these cases:

  • select the line and then select the vertical scrollbar => line stays selected OK
  • select the line and then select the horizontal scrollbar => line stays selected OK

@metas-mk metas-mk self-assigned this Mar 6, 2017
@metas-mk metas-mk closed this as completed Mar 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants