Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Not saved indicator for Grid view lines #447

Closed
metas-mk opened this issue Feb 27, 2017 · 7 comments
Closed

Not saved indicator for Grid view lines #447

metas-mk opened this issue Feb 27, 2017 · 7 comments

Comments

@metas-mk
Copy link
Member

metas-mk commented Feb 27, 2017

Type of issue

Feature request

Current behavior

Currently, Grid view lines that are not saved, are shown and cached but not yet in database. The user cannot see that something is wrong.

Expected behavior

Show unsaved records in a pale red overlay (similar to pulse effect yellow) and when marked with focus and blued out, then show red at least in beginning line/ marker to signal that it's unsaved.

@metas-mk
Copy link
Member Author

metas-mk commented Feb 27, 2017

belongs to #437

@metas-mk metas-mk modified the milestones: 2017-10, 2017-09 Mar 6, 2017
@damianprzygodzki damianprzygodzki self-assigned this Mar 6, 2017
@damianprzygodzki
Copy link
Contributor

I am afraid that the saveStatus is missing for gridview data.
screen shot 2017-03-06 at 16 53 49

@teosarca
Copy link
Member

teosarca commented Mar 6, 2017

@damianprzygodzki , yes... because those are always saved... but i can add it.

question: atm, how the frontend is handling the case when the save status does not exist?

@teosarca
Copy link
Member

teosarca commented Mar 6, 2017

also, can u skip it now for views if not exists?

@damianprzygodzki
Copy link
Contributor

damianprzygodzki commented Mar 7, 2017

Of course! I thought that "Not saved indicator for Grid view lines" means grid view lines :) So we are want to add this in tables in tabs right?

damianprzygodzki added a commit that referenced this issue Mar 7, 2017
@metas-mk metas-mk self-assigned this Mar 8, 2017
metas-mk added a commit to metasfresh/metasfresh that referenced this issue Mar 8, 2017
Add the issue No. metasfresh/metasfresh-webui-frontend-legacy#447 Not saved indicator for Grid view lines to this week's release. Reordering sequence.
@metas-mk
Copy link
Member Author

metas-mk commented Mar 8, 2017

Tested. The not saved indicator for rows works nearly as required (coloring, setting, selected row). But, when editing the record data so that no errors should appear anymore, the coloring is not reset. When ones does a browser refresh, the indicator colors are set properly/ are vanished.
image

@metas-dh
Copy link
Member

Results of IT 2
tested on w101

  • not saved indicator for rows: row is marked red on the left, and coloured pale red, red line in document header: OK
  • resetting of colouring after editing: row is not marked anymore and colour is normal, no more red line in document header: OK
    (tested with rows in purchase & sales order, deleting / adding the product)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants