Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Process result: implement openDocument as modal #676

Closed
teosarca opened this issue Apr 24, 2017 · 9 comments
Closed

Process result: implement openDocument as modal #676

teosarca opened this issue Apr 24, 2017 · 9 comments

Comments

@teosarca
Copy link
Member

Type of issue

Feature request

Current behavior

When frontend is starting a process which returns an "openDocument" action, frontend is opening that document in a new browser tab.

Expected behavior

On "openDocument" action we introduced another field called "modal" (true or false).
If modal:true the document shall be displayed as a modal window (same as HU editor it is now).

Steps to reproduce

  • select a BPartner
  • call the "Create request" action
  • as a result, the "Create request" returns something like:
    image
@teosarca teosarca added this to the 2017-17 milestone Apr 24, 2017
@teosarca
Copy link
Member Author

Required for metasfresh/metasfresh-webui-api-legacy#300

@Dunkat Dunkat self-assigned this Apr 25, 2017
@Dunkat
Copy link
Contributor

Dunkat commented Apr 25, 2017

hello, @teosarca how can I call the "Create request" action? Could you please provide steps?

@teosarca
Copy link
Member Author

Hi @Dunkat

Simple, go to a partner, e.g. https://w101.metasfresh.com:8443/window/123/2156481
and from action menu call "Create request".

damianprzygodzki added a commit that referenced this issue Apr 25, 2017
Process result: implement openDocument as modal #676
@teosarca
Copy link
Member Author

As discussed on skype,

  • the backend will provide "advanced" flag in action response
  • when opening the modal, pls use the caption from layout

@teosarca
Copy link
Member Author

teosarca commented Apr 26, 2017

pls fix: when the modal is opened it shall use the provided documentId and not "NEW":

image

@Dunkat
Copy link
Contributor

Dunkat commented Apr 26, 2017

can't reproduce "NEW" documentId. Probably fixed by the way, but if you find this, please send me how to reproduce.

@teosarca
Copy link
Member Author

then let's integrate and see.
in my case, it's happening ALL the time, no magic.

damianprzygodzki added a commit that referenced this issue Apr 26, 2017
Process result: implement openDocument as modal #676
@teosarca
Copy link
Member Author

test case not working:

damianprzygodzki added a commit that referenced this issue Apr 27, 2017
Provide documentId instead of NEW, disable tabs queried in modal #676
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Apr 28, 2017
[#332](metasfresh/metasfresh-webui-api-legacy#332) Empties window without pre-selection possible
[#695](metasfresh/metasfresh-webui-frontend-legacy#695) Lager photo preview screen/ modal overlay
[#328](metasfresh/metasfresh-webui-api-legacy#328) Manufacturing receipt mandatory Field not filled
[#1388](#1388) HU from Cost Collector is locked and cannot be selected anymore after the CC was reversed
[#683](metasfresh/metasfresh-webui-frontend-legacy#683) Tooltip on first level breadcrumb
[#682](metasfresh/metasfresh-webui-frontend-legacy#682) Sidelist opening shall automatically have the first line selected
[#322](metasfresh/metasfresh-webui-api-legacy#322) Manufacturing Issue/Receipt: Fix Qty and QtyPlan columns
[#676](metasfresh/metasfresh-webui-frontend-legacy#676) Process result: implement openDocument as modal
[#1358](#1358) Drop de.metas.order.callout.CheckDouble
[#411](metasfresh/metasfresh-webui-frontend-legacy#411) Make the parameter names visible in filters
@metas-lc metas-lc self-assigned this May 2, 2017
@metas-lc
Copy link

metas-lc commented May 2, 2017

  • single document / grid view:
  • modal:true
  • type:"openDocument"
  • instead of NEW it's the documentID OK

questions:

  1. after i create a request i have to refresh the page to see it in request tab. Is it OK?
    (created task: request not visible in busines partner tab metasfresh-webui-api-legacy#338)
  2. if i create a request while i am in gridview it asks me if i am sure i want to leave the page (when pressing done in modal). OK?
    (created task leave the page message on request modal #703)

@metas-lc metas-lc closed this as completed May 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants