Empties window without pre-selection possible

[metas-mk]

Is this a bug or feature request?

Feature Request

What is the current behavior?

Currently, you cannot do the Quick actions "Empties ..." w/o selecting a material receipt candidate line.

Which are the steps to reproduce?

Open The Material Receipt candidates window and try.

What is the expected or desired behavior?

Allow the Quick actions for empties also w/o preselecting a line.

[teosarca]

Note to IT: besides task scope, full IT on empties functionality is required

[metas-lc]

IT
tested empties on webui

=> empties receive (Leergut Rücknahme)

• works fine without selecting a line
• works fine selecting a line (bpartner is set)

=> empties return (Leergut Rückgabe)

• works fine without selecting a line
• works fine selecting a line (bpartner is set)

only thing i noticed is that on empties receive, if you create one manually, you have to set the document number. Created issue: metasfresh/metasfresh#1400

[metas-dh]

regression testing for empties in Swing:

Creating empties returns in Wareneingang POS:

• works fine when selecting a line (bpartner is set): only possible for Leergut Rückgabe, from vendor, like before
• works fine without selecting a line: both Leergut Rücknahme & Leergut Rückgabe, like before
• compared the jaspers with Gebindekontokorrent, Gebindesaldo & Gebindeübersicht: empties returns were included and overall Saldi were correct

[metas-lc]

NOK: go to any empties window and create a new one and add a line with add new
=> notice that you have a red line even if you didn't remove any mandatory fields NOK
=> you can't add any product. Nothing is found NOK
(if you add a product from batch entry it works)
see https://w101.metasfresh.com:8443/window/540322/1003737

[metas-lc]

re-checking the issue:
empties windows : 540323 and 540322, 53098 and 53097
=> you can add products with add new OK
=> there is still a red line when you open add new in 540322 and 53098, NOK (save status false: Assumption failure: Product is null")

[teosarca]

Fixed by making the M_Product_ID field (the field and NOT the column) mandatory for those 2 windows (540322 and 53098).
On table level, the M_InOutLine.M_Product_ID is not mandatory because we still have support for description lines (which does not have a product set).
Setting it as mandatory on window/field level would tell the webui that the product is mandatory in that window and the webui shall not try to save it if the product field is not filled.

[metas-rc]

Results of IT

• Empties return and Empties receive are both available for material receipt candidates even if no line is created
• Empties receive has some UI problems but there will be a followup for fixing it on webui :
  Adjustments for Empties Receive Window WebUI metasfresh#1836
• Regression: Emptiese receive and Empties return both work correctly with a pre-selected line