Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Included row: show row's references in context menu #801

Closed
teosarca opened this issue May 26, 2017 · 3 comments
Closed

Included row: show row's references in context menu #801

teosarca opened this issue May 26, 2017 · 3 comments

Comments

@teosarca
Copy link
Member

teosarca commented May 26, 2017

Type of issue

Feature request

Expected behavior

When user is right clicking on an included row, below "Zoom into" and "Advanced edit" please also render row's referenced documents.
To fetch them pls call /rest/api/window/{windowId}/{documentId}/{tabId}/{rowId}/references endpoint.

I would suggest to not wait for "/references" endpoint and then show the popup but the popup shall be displayed ASAP and at the place where the references will be (if it will be!) show something like "(gear) finding references...".
As soon as the endpoint responds, the "(gear) finding references..." shall vanish and in place the actual references shall be shown.
If there were no references then show nothing.

It shall look something like this:
image

Backend task: metasfresh/metasfresh-webui-api-legacy#414

@teosarca teosarca added this to the 2017-22 milestone May 26, 2017
@Dunkat Dunkat self-assigned this May 29, 2017
Dunkat added a commit that referenced this issue May 29, 2017
damianprzygodzki added a commit that referenced this issue May 29, 2017
Included row: show row's references in context menu #801
@metas-mk
Copy link
Member

@Dunkat
Works nicely, but can you please open the window in a new Tab (same as zoom-to). Not a Bug but additional/ forgotten requirement. Thx. ;-)

@cadavre
Copy link
Contributor

cadavre commented May 31, 2017

We are calling additional endpoint /references and waiting for its response. With following statement:

I would suggest to not wait for "/references" endpoint and then show the popup but the popup shall be displayed ASAP and at the place where the references will be (if it will be!) show something like "(gear) finding references...".

It causes UI to blink. Imagine if user wants quickly click Delete but, POP!, in moment he moved mouse to "Delete" references loaded up and "Delete" moved few hundred pixels away.

Small UX suggestion: show references in submenu, call API for /references after user hovers above "Referenced documents". Submenu will show up immediately with spinning loader and load up after API call is done. This will also decrease number of unnecessary API calls.

What I'm talking about ("New" -> "References documents"):
https://upload.wikimedia.org/wikipedia/en/thumb/5/50/Context_menu_windows.png/233px-Context_menu_windows.png

Dunkat added a commit that referenced this issue Jun 1, 2017
damianprzygodzki added a commit that referenced this issue Jun 1, 2017
Open reference window in new tab #801
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jun 1, 2017
[#819](metasfresh/metasfresh-webui-frontend-legacy#819) HTTP header "Accept-Language" shall be correctly set
[#1663](#1663) new order checkup jasper
[#1687](#1687) Refactor Request Tab in Partner Window to allow zoom and advanced edit
[#1239](#1239) Barcode on Bestellkontrolle report
[#428](metasfresh/metasfresh-webui-api-legacy#428) internal: Include AD_Language in layout ETags
[#376](metasfresh/metasfresh-webui-api-legacy#376) Hide Roles on Logon that are not ideal for WebUI
[#426](metasfresh/metasfresh-webui-api-legacy#426) internal: JSONDocument - drop "fields" array field
[#600](metasfresh/metasfresh-webui-frontend-legacy#600) Lookup revamp – collective issue
[#425](metasfresh/metasfresh-webui-api-legacy#425) API support for bookmarking menu items
[#86](metasfresh/metasfresh-webui-api-legacy#86) Check and get rid of "Parameter 'UOMConversion' not found in context" console warnings
[#812](metasfresh/metasfresh-webui-frontend-legacy#812) 1 Key Press save action error during typing
[#1701](#1701) Customer Return Window additional Fields
[#801](metasfresh/metasfresh-webui-frontend-legacy#801) Included row: show row's references in context menu
[#744](metasfresh/metasfresh-webui-frontend-legacy#744) product/packing lookup does nothing when clicking on the single result
[#1640](#1640) fix prepare_services_superuser.sh
[#810](metasfresh/metasfresh-webui-frontend-legacy#810) quickInput endpoints are wrongly called
[#415](metasfresh/metasfresh-webui-api-legacy#415) Notification for Vendor returns jumps to wrong window
[#418](metasfresh/metasfresh-webui-api-legacy#418) Disable zoom into string lookups until it's fixed
[#1644](#1644) Add email validator syntax
[#410](metasfresh/metasfresh-webui-api-legacy#410) Provide view row field zoom-into endpoint

me-45
@metas-mk
Copy link
Member

metas-mk commented Jun 7, 2017

Tested. Works as required. Done.

@metas-mk metas-mk closed this as completed Jun 7, 2017
@metas-mk metas-mk self-assigned this Jun 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants