product/packing lookup does nothing when clicking on the single result

[teosarca]

Type of issue

Bug

Steps to reproduce

NOTE: Happens for a product which has only one packing material

• create new sales order
• batch entry: try "Convenience salad..." which has only one packing material, the IFCO6410.
• OK, now click on the field again
• the dropdown is opened with my "Convenience salad..." product.
• click on that single dropdown option

1. nothing happens
2. while checking the Network tab, remark that each time i click on that the frontend is calling typeahead?query=Convenience ....

Expected behavior

When clicking on that the dropdown shall close, nothing changed.
That's because after selecting the product usually you are asked to pick the packing materials too (the second lookup), but in this case there was only one option so we are not asking.

Of course, in case the second lookup has more then one option, the second lookup's dropdown shall popup next.

[damianprzygodzki]

Lookups are refactored. We should postpone it and test after new widget will come.

[metas-mk]

@damianprzygodzki why postpone? is a functional blocker/ bug.

[damianprzygodzki]

@metas-mk Because @Dunkat is at the end of refactoring lookups. We are going to integrate the brand new widgets soon (~1d) and i believe that it will be faster integrated, than fixed and tested with older widgets.

[teosarca]

Ok, so it shall be fixed by #600

[cadavre]

@metas-lc tested on new lookups?

[teosarca]

To be tested after #600

[metas-mk]

Tested. The following issues occurred:
a) First product row, Product chosen, packing item is shown as a drop-down. This product only has 1 Packing Item, the drop-down is shown. Because it's the only line, the user just has to press enter and tab and can record the qty. OK
b) Create the second row with the same product as the first row, Product is chosen, [enter], then the packing dropdown does not appear. NOK (should be same as a) )
c) Create the next row with a product which does not have any Packing material. The Product is chosen. The dropdown for Packing Material is opened but empty. The user cannot get out of that dropdown w/ keyboard. NOK (should be like in case a) press [enter] w/ empty selection.

[Dunkat]

Fixed:
a,b) when only one item is available, should be selected and no dropdown shown, tested on 'Convenience salad'
c) when product does not have any Packing material press enter to close dropdown

[metas-rc]

IT
Tested on webui

• selecting product with only 1 packing material defined
• => OK: The dropdown is no longer displayed
• => OK: Press tab and get directly to the qty
• Selecting product with no packing material
• => OK: I get the message bellow the product that " There is no choice available"
• => OK: I press enter, then tab => I get to the qty field
• For product with more than 1 packing material, the default one is created but I can only choose another one using the mous. A followup task is already in progress and will be integrated for the next release.
• For products with packing materials defined, I have no posibility to choose "No packing item" if I use the batch entry. I can do it, nevertheless, if I use the Add new button.
  Talked with Mark and this will also be covered in a follow-up task about harmonizing Add New with Batch entry