Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Remaining untranslated static elements in WebUI #924

Closed
metas-mk opened this issue Jun 21, 2017 · 4 comments
Closed

Remaining untranslated static elements in WebUI #924

metas-mk opened this issue Jun 21, 2017 · 4 comments

Comments

@metas-mk
Copy link
Member

metas-mk commented Jun 21, 2017

Type of issue

Feature request

Current behavior

After the first round of making the static elements translatable in WebUI, there are a few remaining elements which were not covered yet.

Expected behavior

Make these also translatable. Some already have their ad_messages.

Sitemap "Type phrase here":
image
image

Browse whole Tree:
image

Expand:
image

Filters:
image

x Items selected:
image

Filter by:
image

Actions/ Selection attributes/ Select element to ...
image

Actions here too:
image

Belongs to this main Issue: #861

@metas-mk metas-mk added this to the 2017-26 milestone Jun 21, 2017
@cadavre cadavre modified the milestones: 2017-26, 2017-27 Jun 26, 2017
@damianprzygodzki
Copy link
Contributor

window.actions.emptyText: "There is no actions",
window.quickActions.caption: "Actions",
window.selectionAttributes.caption: "Selection attributes",
window.selectionAttributes.callToAction: "Select element to display its attributes.",
window.filters.caption2: 'Filter by',
window.table.expand: 'Expand',
window.table.collapse: 'Collapse',
window.sitemap.callToAction: 'Browse whole tree'

damianprzygodzki added a commit that referenced this issue Jun 26, 2017
damianprzygodzki added a commit that referenced this issue Jun 26, 2017
@teosarca
Copy link
Member

window.filters.caption2: 'Filter by',

Here i would make it 'Filter by %(name)s' because sentence ordering in different languages.
And in general, we shall apply this rule everywhere where you see that you have to concatenate strings.

@damianprzygodzki
Copy link
Contributor

Here i would make it 'Filter by %(name)s' because sentence ordering in different languages.
And in general, we shall apply this rule everywhere where you see that you have to concatenate strings.

I wouldn't because it isn't full sentence, just enumeration, and i would like avoid including punctuation in translations. We have buttons with:

Filter: 1, 2, 3

Or

Filter by: 1, 2, 3

damianprzygodzki added a commit that referenced this issue Jun 27, 2017
damianprzygodzki added a commit that referenced this issue Jun 27, 2017
metas-mk added a commit to metasfresh/metasfresh that referenced this issue Jun 28, 2017
Adding a new Issue to next week's release notes for Release 5.16
metasfresh/metasfresh-webui-frontend-legacy#924 Remaining untranslated static elements in WebUI
@metas-mk
Copy link
Member Author

Tested. Opened Follow Up Issue for remaining Bug/ missing Translation. Closing this one. Done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants