Larger photo preview screen/ modal overlay

[metas-mk]

Type of issue

Feature request

Current behavior

Currently, when capturing a photo via the material receipt window, a small preview screen is shown in the bottom right corner.

Expected behavior

The user needs to precisely see if everything is captured on the photo (quality reasons). Please enlarge the preview screen to screen wide overlay.

[metas-mk]

Why not directly open the webcam preview (as wide as modal overlay screen) when opening this already existing overlay. the user can then press on image or start button directly to make the foto.

[metas-dh]

Results of IT1
tested on w101

• webcam preview (as wide as modal overlay screen): smaller than modal overlay screen, see pic, not sure this is big enough?
• user can then press on image or start button directly to make the foto: pressing on the image worked, but pressing the start button doesn't do anything: NOK
• allow escape to get back or press outside: not working, also pressing Cancel does not have any affect, i had to mark the URL and press Enter to get back to Wareneingangsdispo: NOK

@metas-mk: is this webcam preview big enough?

[metas-dh]

checked with mk: webcam preview is big enough: OK

pls fix the other 2 NOKs (see above)

[teosarca]

also i think it would look better if you would gray out everything which is behind. wdyt?

[damianprzygodzki]

@metas-dh

user can then press on image or start button directly to make the foto: pressing on the image worked, but pressing the start button doesn't do anything: NOK

The start button shouldn't take a capture. At least i can't see that it is a case of that issue and has been never discussed.

[metas-dh]

@damianprzygodzki: checked again with mk: nothing happening for pressing Start button is OK

BUT: performance is not acceptable, taking picture when clicking on it takes far too long, used to be much faster!

[damianprzygodzki]

@metas-dh It is not a performance question. We are waiting for the API calls, to close the camera view when everything will be ready.

I can remove that if you want. But then, we have to still wait for the API to load preview.

[teosarca]

Hi guys,

took a quick look on this task...

1. frontend it's uploading the webcam photo (~0.5Mb) => backend it's very slow (851ms) => IMHO that's a thing we need to address on backend side
2. frontend it's querying the image we just uploaded it (took 637ms) => wondering if instead of querying it again, what if frontend would just update directly the image widget:

• set the image ID received on 1.
• set the webcam captured image

wdyt?

[damianprzygodzki]

We can, but:

• it is taking less time than upload (so it is minor issue)
• and what if there will be some image processing (size/format unification, validation) on the backend side, and we would be automatically update the view?
• or the error (500, 400 or timeout)

Fetching state from API right after user action make us sure that we are up to date with API state.

[teosarca]

TODO: create another issue to handle the speed improvements.
On this task we can accept the work as it is.

[teosarca]

=> follow-up: metasfresh/metasfresh-webui-api-legacy#350