Add Builder to CommentEntry instead of of

#6504
metasfresh · Apr 24, 2020 · 1b00abc · 1b00abc
1 parent 3868d7b
commit 1b00abc
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/de.metas.adempiere.adempiere/base/src/main/java/de/metas/comments/CommentEntry.java b/de.metas.adempiere.adempiere/base/src/main/java/de/metas/comments/CommentEntry.java
@@ -23,6 +23,7 @@
 package de.metas.comments;
 
 import de.metas.user.UserId;
+import lombok.Builder;
 import lombok.NonNull;
 import lombok.Value;
 
@@ -39,17 +40,16 @@ public class CommentEntry
 
 	@NonNull CommentEntryId id;
 
-	private CommentEntry(@NonNull final UserId createdBy, @NonNull final ZonedDateTime created, @NonNull final String text, @NonNull final CommentEntryId id)
+	@Builder
+	private CommentEntry(
+			@NonNull final UserId createdBy,
+			@NonNull final ZonedDateTime created,
+			@NonNull final String text,
+			@NonNull final CommentEntryId id)
 	{
 		this.createdBy = createdBy;
 		this.created = created;
 		this.text = text;
 		this.id = id;
 	}
-
-	@NonNull
-	public static CommentEntry of(@NonNull final UserId createdBy, @NonNull final ZonedDateTime created, @NonNull final String text, @NonNull final CommentEntryId id)
-	{
-		return new CommentEntry(createdBy, created, text, id);
-	}
 }
diff --git a/...etas.adempiere.adempiere/base/src/main/java/de/metas/comments/CommentEntryRepository.java b/...etas.adempiere.adempiere/base/src/main/java/de/metas/comments/CommentEntryRepository.java
@@ -95,7 +95,12 @@ private static CommentEntry toRecordComment(@NonNull final I_CM_ChatEntry chatEn
 		final String text = chatEntry.getCharacterData();
 		final CommentEntryId id = CommentEntryId.ofRepoId(chatEntry.getCM_ChatEntry_ID());
 
-		return CommentEntry.of(createdBy, created, text, id);
+		return CommentEntry.builder()
+				.created(created)
+				.createdBy(createdBy)
+				.text(text)
+				.id(id)
+				.build();
 	}
 
 	@NonNull