Remove C_Order.MProductChange callout, and the unused java code.

That callout can be removed as it was only used in swing. #6868
metasfresh · Jun 17, 2020 · 5ff2cf2 · 5ff2cf2
1 parent edd5c89
commit 5ff2cf2
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 91 deletions.
diff --git a/...system/10-de.metas.adempiere/5561640_sys_gh6868_Remove_C_Order.MProductChange_Callout.sql b/...system/10-de.metas.adempiere/5561640_sys_gh6868_Remove_C_Order.MProductChange_Callout.sql
@@ -0,0 +1,5 @@
+-- 2020-06-17T12:22:28.432Z
+-- I forgot to set the DICTIONARY_ID_COMMENTS System Configurator
+DELETE FROM AD_ColumnCallout WHERE AD_ColumnCallout_ID=540999
+;
+
diff --git a/...end/de.metas.handlingunits.base/src/main/java/de/metas/handlingunits/callout/C_Order.java b/...end/de.metas.handlingunits.base/src/main/java/de/metas/handlingunits/callout/C_Order.java
@@ -32,8 +32,6 @@
 import de.metas.adempiere.callout.OrderFastInput;
 import de.metas.handlingunits.model.I_C_Order;
 import de.metas.handlingunits.order.api.IHUOrderBL;
-import de.metas.product.ProductId;
-import de.metas.util.Check;
 import de.metas.util.Services;
 
 public class C_Order extends OrderFastInput
@@ -90,16 +88,4 @@ public void onMengeCU(final ICalloutField calloutField)
 	{
 		evalProductQtyInput(calloutField);
 	}
-
-	public String onMProductChange(final ICalloutField calloutField)
-	{
-		final I_C_Order order = calloutField.getModel(I_C_Order.class);
-		Check.assumeNotNull(order, "Order cannot be null");
-
-		final ProductId quickInputProductId = ProductId.ofRepoIdOrNull(order.getM_Product_ID());
-
-		Services.get(IHUOrderBL.class).findM_HU_PI_Item_Product(order, quickInputProductId, order::setM_HU_PI_Item_Product);
-		return NO_ERROR;
-	}
-
 }
diff --git a/...e.metas.handlingunits.base/src/main/java/de/metas/handlingunits/order/api/IHUOrderBL.java b/...e.metas.handlingunits.base/src/main/java/de/metas/handlingunits/order/api/IHUOrderBL.java
@@ -110,16 +110,5 @@ public interface IHUOrderBL extends ISingletonService
 	 */
 	boolean hasTUs(Properties ctx, int bpartnerId, int productId, Date date);
 
-	/**
-	 * Find best matching {@link I_M_HU_PI_Item_Product} for given <code>product</code> and <code>order</code>.
-	 *
-	 * If an {@link I_M_HU_PI_Item_Product} was found, the consumer fill be called.
-	 *
-	 * @param order
-	 * @param productId
-	 * @param pipConsumer {@link I_M_HU_PI_Item_Product} consumer
-	 */
-	void findM_HU_PI_Item_Product(org.compiere.model.I_C_Order order, ProductId productId, Consumer<I_M_HU_PI_Item_Product> pipConsumer);
-
 	void findM_HU_PI_Item_ProductForForecast(I_M_Forecast forecast, ProductId productId, Consumer<I_M_HU_PI_Item_Product> pipConsumer);
 }
diff --git a/...tas.handlingunits.base/src/main/java/de/metas/handlingunits/order/api/impl/HUOrderBL.java b/...tas.handlingunits.base/src/main/java/de/metas/handlingunits/order/api/impl/HUOrderBL.java
@@ -469,72 +469,6 @@ public boolean hasTUs(final Properties ctx, final int bpartnerId, final int prod
 		return piItemProductDAO.matches(ctx, queryVO, ITrx.TRXNAME_None);
 	}
 
-	@Override
-	public void findM_HU_PI_Item_Product(final org.compiere.model.I_C_Order order, final ProductId productId, final Consumer<I_M_HU_PI_Item_Product> pipConsumer)
-	{
-		//
-		// services
-		final IHUDocumentHandlerFactory huDocumentHandlerFactory = Services.get(IHUDocumentHandlerFactory.class);
-		final IHUPIItemProductDAO hupiItemProductDAO = Services.get(IHUPIItemProductDAO.class);
-
-		Check.assumeNotNull(order, "Order cannot be null");
-
-		final BPartnerId bpartnerId = BPartnerId.ofRepoIdOrNull(order.getC_BPartner_ID());
-		if (bpartnerId == null || order.getDateOrdered() == null)
-		{
-			// in case order's C_BPartner_ID or DateOrdered are null
-			// (i.e. when we just hit New to create a new order), there is no point to search for M_HU_PI_Item_Product record.
-			// Please assume M_HU_PI_Item_Product is null immediately
-
-			return;
-		}
-
-		//
-		// Try fetching the PIP from pricing
-		final IHUDocumentHandler handler = huDocumentHandlerFactory.createHandler(I_C_Order.Table_Name);
-		if (null != handler && productId != null)
-		{
-			final I_M_HU_PI_Item_Product overridePip = handler.getM_HU_PI_ItemProductFor(order, productId);
-			// If we have a default price and it has an M_HU_PI_Item_Product, suggest it in quick entry.
-			if (null != overridePip && overridePip.getM_HU_PI_Item_Product_ID() > 0)
-			{
-				if (overridePip.isAllowAnyProduct())
-				{
-					pipConsumer.accept(null);
-				}
-				else
-				{
-					pipConsumer.accept(overridePip);
-				}
-				return;
-			}
-		}
-
-		//
-		// Try fetching best matching PIP
-		final I_M_HU_PI_Item_Product pip = hupiItemProductDAO.retrieveMaterialItemProduct(
-				productId,
-				bpartnerId,
-				TimeUtil.asZonedDateTime(order.getDateOrdered()),
-				X_M_HU_PI_Version.HU_UNITTYPE_TransportUnit,
-				true); // allowInfiniteCapacity = true
-
-		if (pip == null)
-		{
-			// nothing to do, product is not included in any Transport Units
-			return;
-		}
-
-		else if (pip.isAllowAnyProduct())
-		{
-			return;
-		}
-		else
-		{
-			pipConsumer.accept(pip);
-		}
-	}
-
 	@Override
 	public void findM_HU_PI_Item_ProductForForecast(@NonNull final I_M_Forecast forecast, final ProductId productId, final Consumer<I_M_HU_PI_Item_Product> pipConsumer)
 	{