ProductsToPickViewFactory: Inject the constructor via Spring instead …

…of SpringContextHolder (#6970) #6949
metasfresh · Jul 7, 2020 · 9d6fda6 · 9d6fda6
1 parent 2b05b8d
commit 9d6fda6
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/...api/src/main/java/de/metas/ui/web/pickingV2/productsToPick/ProductsToPickViewFactory.java b/...api/src/main/java/de/metas/ui/web/pickingV2/productsToPick/ProductsToPickViewFactory.java
@@ -54,7 +54,6 @@
 import de.metas.util.StringUtils;
 import lombok.NonNull;
 import org.adempiere.service.ISysConfigBL;
-import org.compiere.SpringContextHolder;
 import org.compiere.util.Env;
 
 import java.util.ArrayList;
@@ -67,9 +66,14 @@ public class ProductsToPickViewFactory implements IViewFactory
 	private static final String MSG_PickCaption = "de.metas.ui.web.pickingV2.productsToPick.Pick.caption";
 	private static final String MSG_ReviewCaption = "de.metas.ui.web.pickingV2.productsToPick.Review.caption";
 
-	private final ProductsToPickRowsService rowsService = SpringContextHolder.instance.getBean(ProductsToPickRowsService.class);
+	private final ProductsToPickRowsService rowsService;
 	private IViewsRepository viewsRepository;
 
+	public ProductsToPickViewFactory(final ProductsToPickRowsService rowsService)
+	{
+		this.rowsService = rowsService;
+	}
+
 	@Override
 	public void setViewsRepository(final IViewsRepository viewsRepository)
 	{