Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul the C_Tax business logic for OSS #11130

Open
adi-stefan opened this issue May 21, 2021 · 0 comments
Open

Overhaul the C_Tax business logic for OSS #11130

adi-stefan opened this issue May 21, 2021 · 0 comments
Labels
branch:blonde_monkey_uat branch:master branch:release cmp:backend backend issue (cmp="component") in:5.170_release

Comments

@adi-stefan
Copy link
Contributor

Is this a bug or feature request?

FR

What is the current behavior?

Which are the steps to reproduce?

What is the expected or desired behavior?

de.metas.tax.api.ITaxBL is in dire need of a refactor
@adi-stefan adi-stefan added the cmp:backend backend issue (cmp="component") label May 21, 2021
@adi-stefan adi-stefan mentioned this issue Jun 8, 2021
Merged
metas-ts added a commit that referenced this issue Jun 25, 2021
@metas-ts
Tweak C_Tax window; Fix: always filter C_Tax by org; tweak logging
697ea11 
also make orgId non-null to reduce FUD and because we always have it anyways

#11130
metas-ts added a commit that referenced this issue Jun 25, 2021
@metas-ts
Fix sql error
f8e02e4 
#11130
metas-ts added a commit that referenced this issue Jun 25, 2021
@metas-ts
remove obsolete unit tests
6e6b860 
#11130
metas-ts added a commit that referenced this issue Jun 25, 2021
@metas-ts
support C_Fiscal_Representation.ValidTo to be non-mandatory
d424456 
#11130
metas-ts added a commit that referenced this issue Jun 25, 2021
@metas-ts
smallbusiness only plays a role in purchase case
ac24916 
Also TaxQuery: introduce SOTrx instead of bool
#11130
metas-ts added a commit that referenced this issue Jun 25, 2021
@metas-ts
2 fixes:
e0f3f94 
* fix NPE if C_Tax.Country_ID not set
* remove obsolete retrieveIsTaxExemptSmallBusiness block
#11130
metas-ts added a commit that referenced this issue Jun 25, 2021
@metas-ts
support deleting invoice lines that are in a verification set
18eb1fa 
#11130
metas-ts added a commit that referenced this issue Jun 27, 2021
@metas-ts
Fix VatTaxId related problem
4b67d55 
#11130
metas-ts added a commit that referenced this issue Jun 28, 2021
@metas-ts
make bpartner-location mandatory; fix bug wrt vat-id
41a2cc6 
#11130
metas-ts added a commit that referenced this issue Jun 28, 2021
@metas-ts
C_Tax: allow Y/N/null for tax-certificate, small-business & fiscal-repr
89c8d5e 
this allows the help message and the code to be simpler

#11130
metas-ts added a commit that referenced this issue Jun 28, 2021
@metas-ts
C_Tax: allow Y/N/null for tax-certificate, small-business & fiscal-repr
9a69819 
fix SQL problem
#11130
metas-ts added a commit that referenced this issue Jun 29, 2021
@metas-ts
fix problem with OSS and deliverey to non-EU
6eed7d7 
#11130
@metas-ts metas-ts changed the title Overhaul the C_Tax business logic Overhaul the C_Tax business logic for OSS Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch:blonde_monkey_uat branch:master branch:release cmp:backend backend issue (cmp="component") in:5.170_release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@metas-ts @adi-stefan