Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New BPartner window: Multiple contacts #11195

Open
BodorAnnamaria opened this issue May 28, 2021 · 0 comments
Open

New BPartner window: Multiple contacts #11195

BodorAnnamaria opened this issue May 28, 2021 · 0 comments

Comments

@BodorAnnamaria
Copy link
Contributor

Is this a bug or feature request?

FR

What is the current behavior?

Which are the steps to reproduce?

What is the expected or desired behavior?

  1. Change the layout of the window New Business Partner id:540327
  2. Create new table C_BPartner_Contact_QuickInput
  3. Contact in New Business Partner id:540327 should be created by the inline tab C_BPartner_Contact_QuickInput
@BodorAnnamaria BodorAnnamaria added the cmp:backend backend issue (cmp="component") label May 28, 2021
BodorAnnamaria added a commit that referenced this issue May 28, 2021
#11195
- window change and create the new C_BPartner_Contact_QuickInput table
BodorAnnamaria added a commit that referenced this issue May 31, 2021
BodorAnnamaria added a commit that referenced this issue May 31, 2021
#11195
- keep C_Greeting_ID field in  C_BPartner_QuickInput
BodorAnnamaria added a commit that referenced this issue Jun 7, 2021
BodorAnnamaria added a commit that referenced this issue Jun 7, 2021
metas-rc added a commit that referenced this issue Jun 17, 2021
* prototyping

* prototyping

* #11195 New BPartner window: Multiple contacts
#11195
- window change and create the new C_BPartner_Contact_QuickInput table

* prototyping

* #11195 New BPartner window: Multiple contacts
#11195
- generate models

* #11195 New BPartner window: Multiple contacts
#11195
- keep C_Greeting_ID field in  C_BPartner_QuickInput

* prototyping

* prototyping

* prototyping

* minor

* prototyping

* Update the includedTabsInfo with the patch if that is present in the response

* Add some logic to render the inlineTab in modal to allow addition

* Obj param to mapDataToStore

* Revert the changes to mapDtaToState

* Adapt for allowing patch within the modal

* move BPartner quick input classes to de.metas.business to be able to use BPartnerComposite

* StringUtils.trimBlankToOptional; QA

* CountryId.equalsToRepoIdu

* PostalId.optionalOfRepoId

* InvoiceRule: minor QA

* BPartnerComposite: refactor & improve in order to make it useful for internal API use

* #11224 Problem on displaying Inline tab in modal window
#11224
- display inline tab in advanced edit view

* #11195New BPartner window: Multiple contacts
#11195
- add Trl for the new tab

* fix unit test, make it not system TZ dependent

* fix unit test

* fix unit tests

* BPartnerContact.newsletter, membershipContact, subjectMatterContact; QA

* fix typo

* fix tests

* #11195New BPartner window: Multiple contacts
#11195
- remove unused code

* minor

* QA, avoid NPE

* QA, avoid NPE

* GreetingStandardType prototyping

* GreetingMap.getComposite

* QA

* fix compile errors

* ModelDynAttributeAccessor.temporarySetValue

* BP quick input fixes & improvements

* BP quick input fixes & improvements

* When NEW winddow created consider the includedTabsInfo

(cherry picked from commit f15caef)

* Update data in included tabs with NEW api endpoint call

(cherry picked from commit ce3bb10)

* Pass the disconnected flag (inlineTab indicator) to Lookup list

(cherry picked from commit 8b5084f)

* Add websocket connection to the Modal (#11242)

* Add websocket connection to the Modal

* Pass the websocket topic

* Use fireUpdateData to refresh the data on websocket event

* Add link to sample issue

* Add extra params to have proper updates

* Add safety check

* Fix issue in advanced edit

Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com>

* It's OK to create a new BPartnerComposite without any of bpartner.id, bpartner.code, bpartner.externalId or one location.gln field set.

* hotfix BPartnerQuickInputService

* RecordWindowFinder.ignoreExcludeFromZoomTargetsFlag

* NewRecordDescriptorsProvider: get the configured window for C_BPartner_QuickInput instead of hardcoding it

* UserPermissions: improve return values

* C_BPartner_QuickInput callout: set AD_Org_ID from Postal

* on save make sure user can create an BP on required Org

* prototyping

* #11282 Introduce C_BPartner_QuickInput_Attributes, 2, 3, 4, 5 and C_BPartner_Contact_QuickInput_Attributes (#11291)

#11282

* #11300 New ExcludeFromPromotions and Referrer columns in C_BPartnert_QuickInput Table (#11301)

* #11300 New ExcludeFromPromotions and Referrer columns in C_BPartnert_QuickInput Table
#11300

* #11300 New ExcludeFromPromotions and Referrer columns in C_BPartnert_QuickInput Table
#11300
- Hide Is Membership Contact from default window

* Update 5593020_sys_gh11300_CreateNewColumnsC_BPartner_QuickInput.sql

remove empty lines

* #11300 New ExcludeFromPromotions and Referrer columns in C_BPartnert_QuickInput Table
#11300
- rename file

* fix after merge from subtasks

* copy contact attributes

* membership BPNameAndGreeting Strategy

#11312

* fix

* more tests and cleanup

#11312

* Only update existing C_BParter if the AD_Userr was manually added/changed/deleted

#11312

* QA/fix MembershipContactBPartnerNameAndGreetingStrategy

* drop BPartnerNameAndGreetingStrategyCode

* Test corrections after merge

#11312

* trl

#11312

* OrgChangeService: move OrgChangeCommand related code to OrgChangeCommand

* minor

* Fix downdown api call for inlineTab

* Fix typeahead also for inlinetab

* Fix by using just the dataId

Co-authored-by: BodorAnnamaria <annamaria.bodor@metasfresh.com>
Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com>
Co-authored-by: Petrica Nanca <petrica_nanca@yahoo.com>
Co-authored-by: metas-rc <ruxandra.craciunescu@metasfresh.com>
Co-authored-by: BodorAnnamaria <73820536+BodorAnnamaria@users.noreply.github.com>
adi-stefan pushed a commit that referenced this issue Jun 18, 2021
* prototyping

* prototyping

* #11195 New BPartner window: Multiple contacts
#11195
- window change and create the new C_BPartner_Contact_QuickInput table

* prototyping

* #11195 New BPartner window: Multiple contacts
#11195
- generate models

* #11195 New BPartner window: Multiple contacts
#11195
- keep C_Greeting_ID field in  C_BPartner_QuickInput

* prototyping

* prototyping

* prototyping

* minor

* prototyping

* Update the includedTabsInfo with the patch if that is present in the response

* Add some logic to render the inlineTab in modal to allow addition

* Obj param to mapDataToStore

* Revert the changes to mapDtaToState

* Adapt for allowing patch within the modal

* move BPartner quick input classes to de.metas.business to be able to use BPartnerComposite

* StringUtils.trimBlankToOptional; QA

* CountryId.equalsToRepoIdu

* PostalId.optionalOfRepoId

* InvoiceRule: minor QA

* BPartnerComposite: refactor & improve in order to make it useful for internal API use

* #11224 Problem on displaying Inline tab in modal window
#11224
- display inline tab in advanced edit view

* #11195New BPartner window: Multiple contacts
#11195
- add Trl for the new tab

* fix unit test, make it not system TZ dependent

* fix unit test

* fix unit tests

* BPartnerContact.newsletter, membershipContact, subjectMatterContact; QA

* fix typo

* fix tests

* #11195New BPartner window: Multiple contacts
#11195
- remove unused code

* minor

* QA, avoid NPE

* QA, avoid NPE

* GreetingStandardType prototyping

* GreetingMap.getComposite

* QA

* fix compile errors

* ModelDynAttributeAccessor.temporarySetValue

* BP quick input fixes & improvements

* BP quick input fixes & improvements

* When NEW winddow created consider the includedTabsInfo

(cherry picked from commit f15caef)

* Update data in included tabs with NEW api endpoint call

(cherry picked from commit ce3bb10)

* Pass the disconnected flag (inlineTab indicator) to Lookup list

(cherry picked from commit 8b5084f)

* Add websocket connection to the Modal (#11242)

* Add websocket connection to the Modal

* Pass the websocket topic

* Use fireUpdateData to refresh the data on websocket event

* Add link to sample issue

* Add extra params to have proper updates

* Add safety check

* Fix issue in advanced edit

Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com>

* It's OK to create a new BPartnerComposite without any of bpartner.id, bpartner.code, bpartner.externalId or one location.gln field set.

* hotfix BPartnerQuickInputService

* RecordWindowFinder.ignoreExcludeFromZoomTargetsFlag

* NewRecordDescriptorsProvider: get the configured window for C_BPartner_QuickInput instead of hardcoding it

* UserPermissions: improve return values

* C_BPartner_QuickInput callout: set AD_Org_ID from Postal

* on save make sure user can create an BP on required Org

* prototyping

* #11282 Introduce C_BPartner_QuickInput_Attributes, 2, 3, 4, 5 and C_BPartner_Contact_QuickInput_Attributes (#11291)

#11282

* #11300 New ExcludeFromPromotions and Referrer columns in C_BPartnert_QuickInput Table (#11301)

* #11300 New ExcludeFromPromotions and Referrer columns in C_BPartnert_QuickInput Table
#11300

* #11300 New ExcludeFromPromotions and Referrer columns in C_BPartnert_QuickInput Table
#11300
- Hide Is Membership Contact from default window

* Update 5593020_sys_gh11300_CreateNewColumnsC_BPartner_QuickInput.sql

remove empty lines

* #11300 New ExcludeFromPromotions and Referrer columns in C_BPartnert_QuickInput Table
#11300
- rename file

* fix after merge from subtasks

* copy contact attributes

* membership BPNameAndGreeting Strategy

#11312

* fix

* more tests and cleanup

#11312

* Only update existing C_BParter if the AD_Userr was manually added/changed/deleted

#11312

* QA/fix MembershipContactBPartnerNameAndGreetingStrategy

* drop BPartnerNameAndGreetingStrategyCode

* Test corrections after merge

#11312

* trl

#11312

* OrgChangeService: move OrgChangeCommand related code to OrgChangeCommand

* minor

* Fix downdown api call for inlineTab

* Fix typeahead also for inlinetab

* Fix by using just the dataId

Co-authored-by: BodorAnnamaria <annamaria.bodor@metasfresh.com>
Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com>
Co-authored-by: Petrica Nanca <petrica_nanca@yahoo.com>
Co-authored-by: metas-rc <ruxandra.craciunescu@metasfresh.com>
Co-authored-by: BodorAnnamaria <73820536+BodorAnnamaria@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants