Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up ReplicationException #1202

Closed
metas-ts opened this issue Mar 27, 2017 · 1 comment
Closed

Clean up ReplicationException #1202

metas-ts opened this issue Mar 27, 2017 · 1 comment
Labels
branch:release bug_please_use_type:bug_instead type:enhancement

Comments

@metas-ts
Copy link
Member

metas-ts commented Mar 27, 2017 •
edited

Is this a bug or feature request?

Feature

What is the current behavior?

Currently, org.adempiere.server.rpl.exceptions.ReplicationException has an addParameter method which is as of #1197 now also avaiable in AdempiereException.

Therefore, we can now remove this from ReplicationException
metas-ts added a commit that referenced this issue Mar 27, 2017
@metas-ts
Update ReleaseNotes.md
414d54d 
[#1202](#1202) Clean up ReplicationException
metas-ts added a commit that referenced this issue Mar 27, 2017
@metas-ts
Remove obsolete method from ReplicationException and refactor a bit
a0a8019 
refactoring: extract parameter-string building code into one method

Clean up ReplicationException
#1202
@metas-dh
Copy link
Member

metas-dh commented Apr 3, 2017

checked with ts: cannot be tested, putting it to Done.

@metas-dh metas-dh closed this as completed Apr 3, 2017
metas-ts pushed a commit that referenced this issue May 7, 2020
@teosarca
Merge pull request #1202 from metasfresh/gh5210_2
f2ccef2 
Update LetterRestController.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch:release bug_please_use_type:bug_instead type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teosarca @metas-ts @metas-dh