Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow using partner product numbers and name for entering order line #2484

Closed
metasnw opened this issue Sep 15, 2017 · 6 comments
Closed

allow using partner product numbers and name for entering order line #2484

metasnw opened this issue Sep 15, 2017 · 6 comments

Comments

@metasnw
Copy link
Member

metasnw commented Sep 15, 2017

Is this a bug or feature request?

FR

What is the current behavior?

partner related product name and number are printed on documents (order, shipment, etc.) but you can not use them in sales order or purchase order to find products.

Which are the steps to reproduce?

  1. create new sales order
  2. go to batch entry
  3. NOK: using partner product number does not bring any hits

What is the expected or desired behavior?

a) new Virtual Column in M_Product (Businessparter Product)
b) Provide Fallback Szenario for when no Businesspartner is in Context
c) Add the new Virtual Column as Identifier for Product
d) implement the usage of context variables in SQL Columns
--> Will work in All Product_ID Fields (check potential sideffects)

@metas-mk metas-mk added this to the 2017-38 milestone Sep 20, 2017
teosarca added a commit that referenced this issue Sep 21, 2017
teosarca added a commit to metasfresh/metasfresh-webui-api-legacy that referenced this issue Sep 21, 2017
teosarca added a commit to metasfresh/metasfresh-webui-api-legacy that referenced this issue Sep 21, 2017
teosarca added a commit to metasfresh/metasfresh-webui-api-legacy that referenced this issue Sep 21, 2017
teosarca added a commit to metasfresh/metasfresh-webui-api-legacy that referenced this issue Sep 21, 2017
teosarca added a commit to metasfresh/metasfresh-webui-api-legacy that referenced this issue Sep 21, 2017
@teosarca
Copy link
Member

Update:

  • implemented for Order line batch entry and Invoice batch entry
  • unfortunately the suggested solution was not viable so i had to implement it in java, from scratch

teosarca added a commit that referenced this issue Sep 22, 2017
metas-ts added a commit that referenced this issue Sep 24, 2017
[#608](metasfresh/metasfresh-webui-api-legacy#608) CU
Quantity in Excel Export from HU Editor is wrong
[#2477](#2477)
Subscription Import Window Adjustments
[#588](metasfresh/metasfresh-webui-api-legacy#588)
Cloning Feature: Error when cloning BOM
[#2541](#2541) Allow
filtering by product group in window product
[#2538](#2538) Remove
legacy LDAP code
[#576](metasfresh/metasfresh-webui-api-legacy#576)
Implement batch entry for Sales/Purchase Invoice documents
[#2484](#2484) allow
using partner product numbers and name for entering order line
[#2502](#2502) Allow
multiple shipment schedules per orderline
[#2395](#2395) Drop
C_Flatrate_Conditions.IsNewTermCreatesOrder together with java code
[#2529](#2529) Import
System users
[#607](metasfresh/metasfresh-webui-api-legacy#607)
AD_Column.IsMandatory shall be overwritten by MandatoryLogic
[#2514](#2514) Support
importing multiline fields
[#603](metasfresh/metasfresh-webui-api-legacy#603)
Handle incorrect AD_Window_ID in URL
[#1167](metasfresh/metasfresh-webui-frontend-legacy#1167)
Edit Fields in Main Grid View
[#2146](#2146) Implement
Generic Multi Tags / labels for records
[#2501](#2501) Import
Requests
[#2510](#2510) Prevent
users from creating duplicate main prices
[#2344](#2344) Support
version 02 CAMT54 file
[#1197](metasfresh/metasfresh-webui-frontend-legacy#1197)
frontend: export view to excel
[#2482](#2482) Allow
disabling of model interceptors on the fly
[#1194](metasfresh/metasfresh-webui-frontend-legacy#1194)
Use API to fetch the locale
[#591](metasfresh/metasfresh-webui-api-legacy#591)
Filter by warehouse when selecting HUs to issue
[#593](metasfresh/metasfresh-webui-api-legacy#593)
Remove Clone action if not supported
[#2492](#2492) Process
C_Dunning_Candidate_Process fails
[#491](metasfresh/metasfresh-webui-api-legacy#491)
Wrong widget Type for Date-Range in Process Parameter

me-45
@metasnw
Copy link
Member Author

metasnw commented Sep 27, 2017

@teosarca I was testing on w101 this feature but I could not get it to work.
can you check my case and see if I did something wrong:

  1. open https://w101.metasfresh.com:8443/window/143/1000029
  2. add new product via "abcde" or "12345" in batch entry
  3. Expectation: should find convenience salad as i defined partner-related value and name for "Test kunde"

@metasnw metasnw self-assigned this Sep 27, 2017
teosarca added a commit to metasfresh/metasfresh-webui-api-legacy that referenced this issue Sep 27, 2017
@teosarca
Copy link
Member

changes:

  • now we are searching by C_BPartner_Product.ProductNo and ProductName
  • we are NO LONGER searching by C_BPartner_Product.VendorProductNo
  • the lookup will display only C_BPartner_Product.ProductNo

metas-ts pushed a commit that referenced this issue Sep 27, 2017
@metas-ts
Copy link
Member

cherry-picked to release branch

metas-ts pushed a commit to metasfresh/metasfresh-webui-api-legacy that referenced this issue Sep 27, 2017
@metas-dh
Copy link
Member

metas-dh commented Sep 28, 2017

Results of IT1
tested in mf15

  1. set different C_BPartner_Product.ProductNo and C_BPartner_Product.ProductName for 2 bpartners
  2. use these for creating order and invoice lines with batch entry:
  • C_BPartner_Product.ProductNo taken in sales orderline of matching bpartner: OK
  • C_BPartner_Product.ProductName taken in sales invoiceline of matching bpartner: OK
  • C_BPartner_Product.ProductNo taken in purchase orderline of matching bpartner: OK
  • C_BPartner_Product.ProductName taken in purchase invoiceline of matching bpartner: OK
  • C_BPartner_Product.ProductNo and C_BPartner_Product.ProductName NOT taken for another bpartner that has different / no C_BPartner_Product.ProductNo and C_BPartner_Product.ProductName set: OK
  1. regression:
  • using standard ProductNo & ProductName still work fine: OK
  • for both bpartners with and without their own C_BPartner_Product.ProductNo and C_BPartner_Product.ProductName: OK

@metas-dh metas-dh reopened this Sep 28, 2017
@metas-mk metas-mk modified the milestones: 2017-38, 2017-40 Oct 3, 2017
@metas-rc metas-rc self-assigned this Oct 4, 2017
@metas-rc
Copy link
Member

metas-rc commented Oct 4, 2017

Results of IT

Retested this and it works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants