Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commission invoice candidates created too early, directly after sales order #6299

Closed
metas-dh opened this issue Mar 3, 2020 · 0 comments
Closed

Commission invoice candidates created too early, directly after sales order #6299

metas-dh opened this issue Mar 3, 2020 · 0 comments
Labels
branch:master branch:release type:bug

Comments

@metas-dh
Copy link
Member

metas-dh commented Mar 3, 2020

Is this a bug or feature request?

Bug

What is the current behavior?

The commission ICs are created directly after the sales order is completed, not after the delivery.

Which are the steps to reproduce?

  1. Set up commission, make sure the flatrate term has invoice: after delivery set
  2. Create a sales order, with a sales rep set
  3. Complete the order: IC for the sales rep is already created: NOK

What is the expected or desired behavior?

The ICs should only be created after the delivery for the sales order.

(found in e2e, see links for example in me03 issue).
metas-ts added a commit that referenced this issue Apr 1, 2020
@metas-ts
solve commission related problems
cf8bb27 
* CommissionShareHandler: solve #6299 for non-item products
  * note that by default the commission product is in fact such a non-item (i.e. service) product
*  5556000_sys_gh6421_fix_c_flatrate_condition_mandatory_problem.sql: solve #6421 by updating the AD_Column's mandatory logic
* OrderCheckupBuilder: minor unrelated
@metas-ts metas-ts mentioned this issue Apr 1, 2020
Merged
metas-ts added a commit that referenced this issue Apr 1, 2020
@metas-ts
solve commission related problems (#6424)
ad11efc 
* CommissionShareHandler: solve #6299 for non-item products
  * note that by default the commission product is in fact such a non-item (i.e. service) product
*  5556000_sys_gh6421_fix_c_flatrate_condition_mandatory_problem.sql: solve #6421 by updating the AD_Column's mandatory logic
* OrderCheckupBuilder: minor unrelated
metas-ts added a commit that referenced this issue Apr 1, 2020
@metas-ts
solve commission related problems (#6424)
48d2979 
* CommissionShareHandler: solve #6299 for non-item products
  * note that by default the commission product is in fact such a non-item (i.e. service) product
*  5556000_sys_gh6421_fix_c_flatrate_condition_mandatory_problem.sql: solve #6421 by updating the AD_Column's mandatory logic
* OrderCheckupBuilder: minor unrelated

(cherry picked from commit ad11efc)
metas-ts added a commit that referenced this issue Apr 2, 2020
@metas-ts
solve commission related problems (#6424)
c0c34c0 
* CommissionShareHandler: solve #6299 for non-item products
  * note that by default the commission product is in fact such a non-item (i.e. service) product
*  5556000_sys_gh6421_fix_c_flatrate_condition_mandatory_problem.sql: solve #6421 by updating the AD_Column's mandatory logic
* OrderCheckupBuilder: minor unrelated

(cherry picked from commit ad11efc)
@metas-ts metas-ts closed this as completed Apr 3, 2020
metas-ts added a commit that referenced this issue Apr 3, 2020
@metas-ts
6299-app - Commission invoice candidates created too early
8348b8b 
hide invoice rule in flatrate-conditions because it has no meaning
#6299
metas-ts added a commit that referenced this issue Apr 22, 2020
@metas-ts
Gh6459 app (#6469)
70bc3d4 
* fix bug where connection was not returned

#6403
(cherry picked from commit 6f2fb1a)

* solve commission related problems (#6424)

* CommissionShareHandler: solve #6299 for non-item products
  * note that by default the commission product is in fact such a non-item (i.e. service) product
*  5556000_sys_gh6421_fix_c_flatrate_condition_mandatory_problem.sql: solve #6421 by updating the AD_Column's mandatory logic
* OrderCheckupBuilder: minor unrelated

(cherry picked from commit ad11efc)

* WIP - add different EPs - unit tests currently fail

#6459

* WIP - clean up a bit and fix tests

#6459

* 6459-app - add beneficiary columns to invoice and..

..code to extract it from healtcare-XML
also improve logging #6459

* 6459-app - add beneficiary columns to invoice and..

..do a little bit of cleanup
also improve logging #6459

* 6459-app - Allow healtchcare-ch EA invoice

* add attaachment listener to extract beneficiary-bpartner-id from XML into invoice
* pimp AttachmentListener invocation; it is now called whenever am attachment is linked to a record
* fix different problem around UPDATE_REMOVE with bpartner-location and contacts
* fix problem regarding BPartner-creation if current user's org differs from the JSON's target-org
#6459

* fix unit tests

#6459

* Solve bpartner lookup problem when getCreating org master data (#6492)

#6491

* minor changes

* Solve bpartner lookup problem when getCreating org master data

fix unit tests
#6491

* Solve bpartner lookup problem when getCreating org master data

- add property to olcand-JSON that allows to advise metasfresh on the way to lookup existing bpartner data (GLN, externalId or value)
- cleanup in JsonServiceFactory: remove obsolete RecordChangeLogRepository stuff
- improve logging
#6491

* fix unit tests

#6491

* 6493-app - Distinguish betwenn null and not set in BPartner-API (#6494)

* Solve bpartner lookup problem when getCreating org master data (#6492)

#6491

* minor changes

* Solve bpartner lookup problem when getCreating org master data

fix unit tests
#6491

* 6493-app - Distinguish betwenn null and not set in BPartner-API

WIP - start experimenting with bpartner-contact;
many thanks to https://stackoverflow.com/a/48436906/1012103 !

#6493

* Solve bpartner lookup problem when getCreating org master data

- add property to olcand-JSON that allows to advise metasfresh on the way to lookup existing bpartner data (GLN, externalId or value)
- cleanup in JsonServiceFactory: remove obsolete RecordChangeLogRepository stuff
- improve logging
#6491

* fix unit tests

#6491

* 6493-app - Distinguish betwenn null and not set in BPartner-API

WIP - i think the bulk of the code changes is done, but need much more QA

#6493

* unrelated logging improvement

* 6493-app - Distinguish betwenn null and not set in BPartner-API

testing
#6493

* 6493-app - Distinguish betwenn null and not set in BPartner-API

testing
#6493

* unrelated logging improvement - fix unit test

* fix cornercase bug:

if e.g. a location upsert request item was identified by ext-123 and the location's externalId was changed in that request item, then metasfresh lost track of the item, resulting in a nasty exception. this commit fixes that problem

* Allow healtchcare-ch EA invoice #6459

- change POReferenceAsSequenceNoProvider and surrounding code for the document number to be suffixed by a "regular" incremental seqno
- solve some after-merge compile errors

* Allow healtchcare-ch EA invoice #6459

- fix bug regarding different patient and guarantor address
- add normal formatting to healthcare documentNo AD_Sequences

* change currentnext for healthcare-ch

#6459

* Update PageNotFoundException.java

* Update JsonResponseBPartner.java

* Update pom.xml

cleanup

* minor

#6459

* fix unit tests

#6459

* remove update to field-length..prevent problems on custmized instances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch:master branch:release type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@metas-ts @metas-dh @metas-Kay