Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the case that a PO can't load a record #986

Closed
metas-ts opened this issue Feb 17, 2017 · 1 comment
Closed

Handle the case that a PO can't load a record #986

metas-ts opened this issue Feb 17, 2017 · 1 comment
Assignees
@metas-ts @metas-dh
Labels
type:enhancement
Milestone
2017-08

Comments

@metas-ts
Copy link
Member

Is this a bug or feature request?

feature request

What is the current behavior?

currently, if PO is invoked to load a record and can't get it from the DB, then an exception is thrown and an error is logged.

What is the expected or desired behavior?

  1. we need to be able to register handlers that are invoked and check if they can do anything about the situation. In case of a positive answer from the handler, the PO shall retry
  2. we need DLM to provide such a handler, that shall check if the not-loadable-record was archived. In that case the handler shall un-archive the record in question and shall tell the POto retry.
    2.a) also consider showing a message to the user (but there we might need to make sure to collect such events and e.g. only show such a message with all of those events at the end of the transaction)
metas-ts added a commit that referenced this issue Feb 17, 2017
@metas-ts
#986 add initial code; WIP!
ae490ea 
FRESH-1405	#986 Handle the case that a PO can't load a record
@metas-ts metas-ts added this to the 2017-08 milestone Feb 17, 2017
@metas-ts metas-ts self-assigned this Feb 17, 2017
metas-ts added a commit that referenced this issue Feb 18, 2017
@metas-ts
#986 add logging and javadoc; register handler on startup
81b13a8 
FRESH-1405 #986 Handle the case that PO can't load a record
@metas-ts metas-ts mentioned this issue Feb 20, 2017
Merged
metas-ts added a commit that referenced this issue Feb 20, 2017
@metas-ts
#986 use CopyOnWriteArrayList ftw!; also fix a codacy issue
46ad0cd 
FRESH-1405 #986 Handle the case that PO can't load a record
metas-ts added a commit that referenced this issue Feb 21, 2017
@metas-ts
Merge pull request #1001 from metasfresh/gh986
582f128 
#986 Handle the case that PO can't load a record
metas-ts added a commit that referenced this issue Feb 21, 2017
@metas-ts
Update ReleaseNotes.md
755b791 
#986
metas-ts added a commit that referenced this issue Feb 21, 2017
@metas-ts
#986: echo downstream job's build variables
5dac42c 
FRESH-1372 #968 Include webui in the normal rollout process
@metas-dh metas-dh self-assigned this Feb 22, 2017
@metas-dh
Copy link
Member

Results of IT 1

https://github.com/metasfresh/metasfresh-documentation/blob/master/_tests_collection/Testcase_%23986.md: OK

metas-ts added a commit that referenced this issue Mar 5, 2017
@metas-ts
Fix for #986 Handle the case that PO can't load a record
b3ddca9 
* UnarchiveRecordHandler: unarchiving didn't work in-trx
* SQL: aparently, a DDL fix was never stored in a migration script so
far

FRESH-1405 #986 Handle the case that PO can't load a record
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metas-ts metas-ts

@metas-dh metas-dh

Labels
type:enhancement
Projects
None yet
Milestone
2017-08
Development

No branches or pull requests
2 participants
@metas-ts @metas-dh