Create Sales Order from this Quotation: don't show the action if it does not apply #10203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metas-ts
requested changes
Nov 10, 2020
| final boolean isSalesProposalOrQuotation = docTypeBL.isSalesProposalOrQuotation(docTypeId.get()); | ||
| if (!isSalesProposalOrQuotation) | ||
| { | ||
| return ProcessPreconditionsResolution.reject(); |
There was a problem hiding this comment.
Suggested change
| return ProcessPreconditionsResolution.reject(); | |
| return ProcessPreconditionsResolution.rejectWithInternalReason("is not sales proposal or quotation"); |
| } | ||
| else | ||
| { | ||
| ProcessPreconditionsResolution.reject(); |
There was a problem hiding this comment.
Suggested change
| ProcessPreconditionsResolution.reject(); | |
| return ProcessPreconditionsResolution.rejectWithInternalReason("no C_DocTypeTarget_ID"); |
- change rejection message
metas-ts
approved these changes
Nov 12, 2020
metas-ts
pushed a commit
that referenced
this pull request
Dec 9, 2020
metas-ts
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/metasfresh/mf15/issues/396