Fixes for OrderLine.LineNetAmt and Flatrate Conditions #10443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metas-ts
reviewed
Dec 15, 2020
| @@ -46,6 +46,8 @@ public static OrderLinePriceUpdateRequest ofOrderLine(final org.compiere.model.I | |||
| public static OrderLinePriceUpdateRequestBuilder prepare(final org.compiere.model.I_C_OrderLine orderLine) | |||
| { | |||
| return builder() | |||
| .updatePriceEnteredAndDiscountOnlyIfNotAlreadySet(true) | |||
There was a problem hiding this comment.
not sure here..because e.g. if i untick the manual-price checkbox, i want the price reset by the pricing-engine..
There was a problem hiding this comment.
you already fixed/removed this line.
nothing for me to do here, except for more testing.
Hopefully this doesn't break other stuff. In case it does, we can put back the line, and add a callout to un-set PriceEntered if IsManualPrice is unticked.
|
@TheBestPessimist i tested locally and believe that right now it's fine for the use-case we are addressing; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10365