refactoring Haddex #10548
Merged
refactoring Haddex #10548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add haddex validations to: * partner change * promised date changed * order completion
metas-ts
reviewed
Jan 22, 2021
| return false; | ||
| } | ||
|
|
||
| if (partner.getDateHaddexCheck() == null) |
There was a problem hiding this comment.
are we sure this is what we want? what not insisten on a date if isHaddexCheck=true?
There was a problem hiding this comment.
to be handled in a followup
| { | ||
| final IBPartnerDAO partnerDAO = Services.get(IBPartnerDAO.class); | ||
| final org.compiere.model.I_C_BPartner partner = partnerDAO.getById(order.getC_BPartner_ID()); | ||
| final long differenceBetweenHaddexCheckDateAndPromisedDateInMonths = Math.abs( |
There was a problem hiding this comment.
why the abs?
not 100% sure what to do if datePromised is before the haddex, check..but should it really depend on how many moths before it is?
maybe we should simply throw the error also if getDatePromised < getDateHaddexCheck ?
(i guess it's a rare case, so maybe it doesn't make sense to engneer a dedicated error message..)
There was a problem hiding this comment.
to be handled in a followup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add haddex validations to:
#10538